[jira] [Resolved] (GIRAPH-151) IntIntNullIntVertex.initialize method should handle "null" edges argument

2012-07-25 Thread Alessandro Presta (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Presta resolved GIRAPH-151. -- Resolution: Fixed As Paolo noted, this is not an issue anymore. > IntI

[jira] [Commented] (GIRAPH-180) Publish SNAPSHOTs and released artifacts in the Maven repository

2012-07-25 Thread Jakob Homan (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422721#comment-13422721 ] Jakob Homan commented on GIRAPH-180: bq. it would be ideal to make the "giraph" scrip

[jira] [Commented] (GIRAPH-83) Is Vertex correct yet?

2012-07-25 Thread Jakob Homan (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422720#comment-13422720 ] Jakob Homan commented on GIRAPH-83: --- I'd rather not. Even with the new changes, I'm not

[jira] [Updated] (GIRAPH-271) Regression in imports in CommunicationsInterface

2012-07-25 Thread Jaeho Shin (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jaeho Shin updated GIRAPH-271: -- Attachment: GIRAPH-271-1.patch Here's the patch that fixes regression for non-secure Hadoop.

[jira] [Commented] (GIRAPH-244) Vertex API redesign

2012-07-25 Thread Alessandro Presta (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422688#comment-13422688 ] Alessandro Presta commented on GIRAPH-244: -- Here: https://issues.apache.org/jira/

[jira] [Created] (GIRAPH-271) Regression in imports in CommunicationsInterface

2012-07-25 Thread Alessandro Presta (JIRA)
Alessandro Presta created GIRAPH-271: Summary: Regression in imports in CommunicationsInterface Key: GIRAPH-271 URL: https://issues.apache.org/jira/browse/GIRAPH-271 Project: Giraph Issue

[jira] [Commented] (GIRAPH-244) Vertex API redesign

2012-07-25 Thread Alessandro Presta (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422683#comment-13422683 ] Alessandro Presta commented on GIRAPH-244: -- Oh no, that was bad, sorry! It's the

[jira] [Updated] (GIRAPH-244) Vertex API redesign

2012-07-25 Thread Jaeho Shin (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jaeho Shin updated GIRAPH-244: -- Attachment: 0001-GIRAPH-244-regression-for-non-secure-Hadoop.patch There was regression for non-secure

Re: Review Request: Fixing aggregators

2012-07-25 Thread Alessandro Presta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6134/#review9459 --- Perfect, this looks ready to me. While we wait for committers, can you

Re: Review Request: Fixing aggregators

2012-07-25 Thread Maja Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6134/ --- (Updated July 25, 2012, 4:25 p.m.) Review request for giraph. Changes ---

[jira] [Commented] (GIRAPH-259) TestBspBasic.testBspPageRank is broken

2012-07-25 Thread Jan van der Lugt (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422570#comment-13422570 ] Jan van der Lugt commented on GIRAPH-259: - Looks good, Maja! > Te

[jira] [Commented] (GIRAPH-267) Jobs can get killed for not reporting status during INPUT SUPERSTEP

2012-07-25 Thread Jaeho Shin (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422500#comment-13422500 ] Jaeho Shin commented on GIRAPH-267: --- [~initialcontext] I see. It seems we need more get

[jira] [Updated] (GIRAPH-267) Jobs can get killed for not reporting status during INPUT SUPERSTEP

2012-07-25 Thread Jaeho Shin (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jaeho Shin updated GIRAPH-267: -- Attachment: GIRAPH-267.patch Sorry about the hassle. Hopefully the final patch for this issue, includi

[jira] [Commented] (GIRAPH-267) Jobs can get killed for not reporting status during INPUT SUPERSTEP

2012-07-25 Thread Eli Reisman (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422433#comment-13422433 ] Eli Reisman commented on GIRAPH-267: There is already a working patch for this, GIRAPH

[jira] [Updated] (GIRAPH-259) TestBspBasic.testBspPageRank is broken

2012-07-25 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maja Kabiljo updated GIRAPH-259: Attachment: GIRAPH-259-1.patch > TestBspBasic.testBspPageRank is broken > -

[jira] [Commented] (GIRAPH-270) Improve TestManualCheckpoint

2012-07-25 Thread Alessandro Presta (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422377#comment-13422377 ] Alessandro Presta commented on GIRAPH-270: -- Here's a possible way to organize the

[jira] [Created] (GIRAPH-270) Improve TestManualCheckpoint

2012-07-25 Thread Alessandro Presta (JIRA)
Alessandro Presta created GIRAPH-270: Summary: Improve TestManualCheckpoint Key: GIRAPH-270 URL: https://issues.apache.org/jira/browse/GIRAPH-270 Project: Giraph Issue Type: Bug

[jira] [Created] (GIRAPH-269) TestGraphPartitioner is broken and probably not robust

2012-07-25 Thread Alessandro Presta (JIRA)
Alessandro Presta created GIRAPH-269: Summary: TestGraphPartitioner is broken and probably not robust Key: GIRAPH-269 URL: https://issues.apache.org/jira/browse/GIRAPH-269 Project: Giraph

Re: Review Request: Fixing aggregators

2012-07-25 Thread Alessandro Presta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6134/#review9441 --- Looks great! Aggregators are an important feature that we need to get

Re: Review Request: Fixing aggregators

2012-07-25 Thread Maja Kabiljo
> On July 25, 2012, 12:26 p.m., Alessandro Presta wrote: > > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/graph/AggregatorWrapper.java, > > line 67 > > > > > > I would rename this to curr

Re: Review Request: Fixing aggregators

2012-07-25 Thread Alessandro Presta
> On July 25, 2012, 12:26 p.m., Alessandro Presta wrote: > > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/graph/AggregatorUsage.java, > > line 74 > > > > > > Again, you've probably alread

Re: Review Request: Fixing aggregators

2012-07-25 Thread Alessandro Presta
> On July 25, 2012, 12:26 p.m., Alessandro Presta wrote: > > http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/aggregators/BasicAggregator.java, > > line 30 > > > > > > I'm most likely missing

Re: Review Request: Fixing aggregators

2012-07-25 Thread Maja Kabiljo
> On July 25, 2012, 12:26 p.m., Alessandro Presta wrote: > > Looks great! Aggregators are an important feature that we need to get > > right, and this integrates well with the new MasterCompute. > > > > Just a few questions/ideas about design, but this already looks solid. Thanks for looking i

[jira] [Commented] (GIRAPH-83) Is Vertex correct yet?

2012-07-25 Thread Alessandro Presta (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422235#comment-13422235 ] Alessandro Presta commented on GIRAPH-83: - Should we mark this resolved, given most

[jira] [Commented] (GIRAPH-267) Jobs can get killed for not reporting status during INPUT SUPERSTEP

2012-07-25 Thread Alessandro Presta (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422200#comment-13422200 ] Alessandro Presta commented on GIRAPH-267: -- I ran into this too, thanks for addre

Re: Heads up: API redesign

2012-07-25 Thread Gianmarco De Francisci Morales
Congrats! Nice to see the project moving fast (and in the right direction). Cheers, -- Gianmarco On Wed, Jul 25, 2012 at 12:44 PM, Alessandro Presta wrote: > Hi all, > > In case anyone missed this, we just committed a relatively big redesign of > the API that aims for improved consistency and

Heads up: API redesign

2012-07-25 Thread Alessandro Presta
Hi all, In case anyone missed this, we just committed a relatively big redesign of the API that aims for improved consistency and usability. Some patches will need to be rebased. I apologize for the hassle! Most relevant changes: * New iteration strategy: we now iterate over edges instead o

[jira] [Commented] (GIRAPH-259) TestBspBasic.testBspPageRank is broken

2012-07-25 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422133#comment-13422133 ] Maja Kabiljo commented on GIRAPH-259: - https://reviews.apache.org/r/6134/

Review Request: Fixing aggregators

2012-07-25 Thread Maja Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6134/ --- Review request for giraph. Description --- Now by default all aggregators a

[jira] [Resolved] (GIRAPH-243) EdgeListVertex performance is sub-optimal

2012-07-25 Thread Alessandro Presta (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Presta resolved GIRAPH-243. -- Resolution: Fixed Fix included in GIRAPH-244 > EdgeListVertex performa

[jira] [Resolved] (GIRAPH-240) Our vertices shouldn't accept null ids or values

2012-07-25 Thread Alessandro Presta (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Presta resolved GIRAPH-240. -- Resolution: Fixed Fix included in GIRAPH-244 > Our vertices shouldn't

[jira] [Resolved] (GIRAPH-245) BasicRPCCommunications fails with custom vertices

2012-07-25 Thread Alessandro Presta (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Presta resolved GIRAPH-245. -- Resolution: Fixed Fix included in GIRAPH-244 > BasicRPCCommunications

[jira] [Commented] (GIRAPH-180) Publish SNAPSHOTs and released artifacts in the Maven repository

2012-07-25 Thread Alessandro Presta (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422094#comment-13422094 ] Alessandro Presta commented on GIRAPH-180: -- Slightly related: in the long term, i