[jira] [Commented] (GIRAPH-508) Increase the limit on the number of partitions

2013-02-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574230#comment-13574230 ] Hudson commented on GIRAPH-508: --- Integrated in Giraph-trunk-Commit #684 (See [https://build

[jira] [Commented] (GIRAPH-504) Create PartitionContext

2013-02-07 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574161#comment-13574161 ] Maja Kabiljo commented on GIRAPH-504: - https://reviews.apache.org/r/9372/

Review Request: GIRAPH-504: Create PartitionContext

2013-02-07 Thread Maja Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9372/ --- Review request for giraph. Description --- Create PartitionContext as a thr

[jira] [Updated] (GIRAPH-504) Create PartitionContext

2013-02-07 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maja Kabiljo updated GIRAPH-504: Attachment: GIRAPH-504.diff Ok, here is my second take on this. PartitionContext, looks much better

[jira] [Updated] (GIRAPH-504) Create PartitionContext

2013-02-07 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maja Kabiljo updated GIRAPH-504: Summary: Create PartitionContext (was: Create ComputeContext) > Create PartitionContext >

Re: Review Request: GIRAPH-508: Increase the limit on the number of partitions

2013-02-07 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9370/#review16315 --- Ship it! +1 Looks great! giraph-core/src/main/java/org/apache/gir

[jira] [Commented] (GIRAPH-509) Factor out AggregatorUsage

2013-02-07 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574148#comment-13574148 ] Maja Kabiljo commented on GIRAPH-509: - Honestly, that's how it was before I touched ag

[jira] [Commented] (GIRAPH-510) Remove HBase Cruft

2013-02-07 Thread Eli Reisman (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574139#comment-13574139 ] Eli Reisman commented on GIRAPH-510: Yes, please! > Remove HBase Cru

[jira] [Commented] (GIRAPH-509) Factor out AggregatorUsage

2013-02-07 Thread Eli Reisman (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574134#comment-13574134 ] Eli Reisman commented on GIRAPH-509: I have wondered the same thing. I think Maja had

[jira] [Updated] (GIRAPH-503) Refactor platform-independent CLI argument parsing in GiraphRunner into a separate class

2013-02-07 Thread Eli Reisman (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eli Reisman updated GIRAPH-503: --- Attachment: GIRAPH-503-5.patch > Refactor platform-independent CLI argument parsing in GiraphRunn

Re: Review Request: Refactor CLI arg parsing out of GiraphRunner

2013-02-07 Thread Eli Reisman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9350/ --- (Updated Feb. 8, 2013, 1:04 a.m.) Review request for giraph. Changes ---

Re: Review Request: Refactor CLI arg parsing out of GiraphRunner

2013-02-07 Thread Eli Reisman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9350/ --- (Updated Feb. 8, 2013, 12:48 a.m.) Review request for giraph. Changes ---

[jira] [Commented] (GIRAPH-503) Refactor platform-independent CLI argument parsing in GiraphRunner into a separate class

2013-02-07 Thread Eli Reisman (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574110#comment-13574110 ] Eli Reisman commented on GIRAPH-503: One refactor I will put up a JIRA for when this i

[jira] [Updated] (GIRAPH-503) Refactor platform-independent CLI argument parsing in GiraphRunner into a separate class

2013-02-07 Thread Eli Reisman (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eli Reisman updated GIRAPH-503: --- Attachment: GIRAPH-503-4.patch Great reviews on RB guys, thanks again. I have rethought a few things

[jira] [Commented] (GIRAPH-508) Increase the limit on the number of partitions

2013-02-07 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574106#comment-13574106 ] Maja Kabiljo commented on GIRAPH-508: - Sure, https://reviews.apache.org/r/9370

Review Request: GIRAPH-508: Increase the limit on the number of partitions

2013-02-07 Thread Maja Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9370/ --- Review request for giraph. Description --- Make more compact serialization

[jira] [Commented] (GIRAPH-508) Increase the limit on the number of partitions

2013-02-07 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574098#comment-13574098 ] Avery Ching commented on GIRAPH-508: This looks pretty good [~majakabiljo]. Can you t

[jira] [Updated] (GIRAPH-508) Increase the limit on the number of partitions

2013-02-07 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maja Kabiljo updated GIRAPH-508: Attachment: GIRAPH-508.diff > Increase the limit on the number of partitions >

[jira] [Commented] (GIRAPH-509) Factor out AggregatorUsage

2013-02-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574046#comment-13574046 ] Hudson commented on GIRAPH-509: --- Integrated in Giraph-trunk-Commit #683 (See [https://build

Re: Checkpointing off by default

2013-02-07 Thread Claudio Martella
I'd say because the default job/scenario/use case is not long-lasting. Maybe it's somebody running an example, and you do not want to penalize default behaviour with checkpointing overhead? My 2 cents. On Thu, Feb 7, 2013 at 11:16 PM, Sebastian Schelter wrote: > Hi, > > I saw that checkpointin

Checkpointing off by default

2013-02-07 Thread Sebastian Schelter
Hi, I saw that checkpointing is disabled by default. I'd like to know (out of scientific curiosity) why we decided to have this as default. Best, Sebastian

[jira] [Commented] (GIRAPH-503) Refactor platform-independent CLI argument parsing in GiraphRunner into a separate class

2013-02-07 Thread Claudio Martella (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573882#comment-13573882 ] Claudio Martella commented on GIRAPH-503: - Agreed, great work Eli!

Re: Review Request: Refactor CLI arg parsing out of GiraphRunner

2013-02-07 Thread Nitay Joffe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9350/#review16249 --- This is great, I love it. A few notes inline but I fully support this

Review Request: Refactor CLI arg parsing out of GiraphRunner

2013-02-07 Thread Eli Reisman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9350/ --- Review request for giraph. Description --- Refactor CLI parsing of args and

Re: Review Request: GIRAPH-505: Metrics Updates (nitay)

2013-02-07 Thread Alessandro Presta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9341/#review16223 --- Looks good to me, some minor nits. Thanks in particular for fixing th