[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460052#comment-13460052
]
Hudson commented on GIRAPH-277:
---
Integrated in Giraph-trunk-Commit #201 (See
[https://build
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460032#comment-13460032
]
Avery Ching commented on GIRAPH-277:
Looks great and passed the tests. +1, committing
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459468#comment-13459468
]
Avery Ching commented on GIRAPH-277:
Actually, I think i know the issue here.
{code}
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459465#comment-13459465
]
Nitay Joffe commented on GIRAPH-277:
I did, the two errors are the unless you're seei
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459460#comment-13459460
]
Avery Ching commented on GIRAPH-277:
Did you run 'mvn clean verify' with this patch?
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459390#comment-13459390
]
Avery Ching commented on GIRAPH-277:
I don't know why it's not happening in the normal
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459385#comment-13459385
]
Nitay Joffe commented on GIRAPH-277:
1) Will do.
2) Yeah I saw that forgot to comment
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459371#comment-13459371
]
Avery Ching commented on GIRAPH-277:
Nitay, I think we're almost there on this.
1) J
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429475#comment-13429475
]
Jakob Homan commented on GIRAPH-277:
As an aside, for some reason I can't add Jaeho as
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429358#comment-13429358
]
Jaeho Shin commented on GIRAPH-277:
---
Thanks, Jakob. I also found it simple to just keep
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429336#comment-13429336
]
Jakob Homan commented on GIRAPH-277:
I'm not sure aobut the -full-index. I downloaded
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429323#comment-13429323
]
Jaeho Shin commented on GIRAPH-277:
---
I am trying with {{--no-prefix}}, {{--full-index}}
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429301#comment-13429301
]
Jakob Homan commented on GIRAPH-277:
with git you also have to add --no-prefix as git
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428513#comment-13428513
]
Jaeho Shin commented on GIRAPH-277:
---
@Eli, In fact, the preprocessing is already used wi
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428455#comment-13428455
]
Jakob Homan commented on GIRAPH-277:
@Jaeho, please open a reviewboard request for the
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428451#comment-13428451
]
Eli Reisman commented on GIRAPH-277:
If you have a use case where this sort of extra p
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427782#comment-13427782
]
Brian Femiano commented on GIRAPH-277:
--
I'm in favor of anything that makes subclassi
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427736#comment-13427736
]
Jaeho Shin commented on GIRAPH-277:
---
Thanks Eli.
It would be great to entirely eliminat
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427702#comment-13427702
]
Eli Reisman commented on GIRAPH-277:
Oh, and anyone who removes lines from the checkst
[
https://issues.apache.org/jira/browse/GIRAPH-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427697#comment-13427697
]
Eli Reisman commented on GIRAPH-277:
That was a lot of work, good job. This does need
20 matches
Mail list logo
