Re: Review Request: GIRAPH-415: Refactor / cleanup Hadoop Counters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7980/#review13368 --- Ship it! +1, thanks Nitay. - Maja Kabiljo On Nov. 12, 2012, 6:59

Re: Review Request: GIRAPH-415: Refactor / cleanup Hadoop Counters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7980/ --- (Updated Nov. 12, 2012, 6:59 p.m.) Review request for giraph. Changes ---

Re: Review Request: GIRAPH-415: Refactor / cleanup Hadoop Counters

> On Nov. 9, 2012, 7:03 p.m., Maja Kabiljo wrote: > > giraph/src/main/java/org/apache/giraph/graph/BspServiceMaster.java, line 769 > > > > > > You can use setValue here > > Nitay Joffe wrote: > That makes the logic

Re: Review Request: GIRAPH-415: Refactor / cleanup Hadoop Counters

> On Nov. 9, 2012, 7:03 p.m., Maja Kabiljo wrote: > > giraph/src/main/java/org/apache/giraph/counters/GiraphStats.java, line 170 > > > > > > Am I missing something or this is not used? > > I understand the idea of

Re: Review Request: GIRAPH-415: Refactor / cleanup Hadoop Counters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7980/#review13296 --- Looks good. giraph/src/main/java/org/apache/giraph/counters/GiraphS

Review Request: GIRAPH-415: Refactor / cleanup Hadoop Counters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7980/ --- Review request for giraph. Description --- GIRAPH-415: Refactor / cleanup H