Review Request: GIRAPH-515: More efficient and flexible edge-based input

2013-02-14 Thread Alessandro Presta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9449/ --- Review request for giraph. Description --- This patch adds the following cl

Re: Review Request: GIRAPH-515: More efficient and flexible edge-based input

2013-02-14 Thread Maja Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9449/#review16604 --- This is great, and results are promising. Reusing the ideas from impr

Re: Review Request: GIRAPH-515: More efficient and flexible edge-based input

2013-02-14 Thread Alessandro Presta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9449/ --- (Updated Feb. 15, 2013, 1:24 a.m.) Review request for giraph. Changes ---

Re: Review Request: GIRAPH-515: More efficient and flexible edge-based input

2013-02-15 Thread Nitay Joffe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9449/#review16626 --- Cool looks great to me. Maja should take a look but I'm +1 on it. Doe

Re: Review Request: GIRAPH-515: More efficient and flexible edge-based input

2013-02-15 Thread Alessandro Presta
> On Feb. 15, 2013, 4:46 p.m., Nitay Joffe wrote: > > Cool looks great to me. Maja should take a look but I'm +1 on it. Does it > > make any sense to look into making SendMutationsCache and > > SendPartitionCache also use SendCache, or are those too different? I'm not so sure about SendPartiti

Re: Review Request: GIRAPH-515: More efficient and flexible edge-based input

2013-02-15 Thread Alessandro Presta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9449/ --- (Updated Feb. 15, 2013, 6:17 p.m.) Review request for giraph. Description

Re: Review Request: GIRAPH-515: More efficient and flexible edge-based input

2013-02-15 Thread Maja Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9449/#review16659 --- Looks much better now, +1 from me too. giraph-core/src/main/java/or