Re: Review Request: Jython for Giraph

2013-06-09 Thread Nitay Joffe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11709/ --- (Updated June 10, 2013, 6:53 a.m.) Review request for giraph. Summary (update

Re: Review Request: Jython for Giraph

2013-06-09 Thread Nitay Joffe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11709/ --- (Updated June 10, 2013, 6:54 a.m.) Review request for giraph. Description ---

Re: Review Request: Jython for Giraph

2013-06-09 Thread Nitay Joffe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11709/ --- (Updated June 10, 2013, 6:55 a.m.) Review request for giraph. Description (up

Re: Review Request: Jython for Giraph

2013-06-10 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11709/#review21668 --- This is really neat functionality. Looking forward to seeing the ba

Re: Review Request: Jython for Giraph

2013-06-10 Thread Nitay Joffe
> On June 11, 2013, 12:07 a.m., Avery Ching wrote: > > giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java, > > lines 49-66 > > > > > > my personal preference here is for adding boolean exists(Conf

Re: Review Request: Jython for Giraph

2013-06-10 Thread Nitay Joffe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11709/#review21693 --- Regarding your comment - yeah I'll add it to GiraphRunner. Right now

Re: Review Request: Jython for Giraph

2013-06-10 Thread Nitay Joffe
> On June 11, 2013, 5:51 a.m., Nitay Joffe wrote: > > Regarding your comment - yeah I'll add it to GiraphRunner. Right now you > > have to specify at the very least the types IVEMM, the python script path > > (as resource in jar) and the computation class name. Any thoughts how to > > make thi

Re: Review Request: Jython for Giraph

2013-06-10 Thread Claudio Martella
probably this would make sense the hadoop-streaming way through the distributed cache via command-line? On Tue, Jun 11, 2013 at 7:52 AM, Nitay Joffe wrote: > > > > On June 11, 2013, 5:51 a.m., Nitay Joffe wrote: > > > Regarding your comment - yeah I'll add it to GiraphRunner. Right now > you ha

Re: Review Request: Jython for Giraph

2013-06-11 Thread Avery Ching
> On June 11, 2013, 5:51 a.m., Nitay Joffe wrote: > > Regarding your comment - yeah I'll add it to GiraphRunner. Right now you > > have to specify at the very least the types IVEMM, the python script path > > (as resource in jar) and the computation class name. Any thoughts how to > > make thi

Re: Review Request: Jython for Giraph

2013-06-11 Thread Avery Ching
> On June 11, 2013, 12:07 a.m., Avery Ching wrote: > > giraph-core/src/main/java/org/apache/giraph/conf/AbstractConfOption.java, > > lines 49-66 > > > > > > my personal preference here is for adding boolean exists(Conf

Re: Review Request: Jython for Giraph

2013-06-11 Thread Alessandro Presta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11709/#review21705 --- Pretty cool! It will be really useful once there is better support f

Re: Review Request: Jython for Giraph

2013-06-11 Thread Nitay Joffe
> On June 11, 2013, 5:13 p.m., Alessandro Presta wrote: > > Pretty cool! It will be really useful once there is better support for > > types: > > 1) some kind of type inference/casting/automatic serialization, so that one > > can write setValue(4) instead of setValue(IntWritable(4)) > > 2) poss

Re: Review Request: Jython for Giraph

2013-06-11 Thread Nitay Joffe
> On June 11, 2013, 12:07 a.m., Avery Ching wrote: > > giraph-core/src/main/java/org/apache/giraph/jython/JythonComputationFactory.java, > > line 57 > > > > > > Wrapped LOG.info please. > > Nitay Joffe wrote: > Fi