Re: Review Request: Open Netty client and server on master

2012-08-27 Thread Maja Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6753/ --- (Updated Aug. 27, 2012, 8:55 a.m.) Review request for giraph. Changes ---

Re: Review Request: Open Netty client and server on master

2012-08-27 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6753/#review10788 --- Ship it! I'm +1'ed on this. Thanks for the changes Maja. This is

Re: Review Request: Open Netty client and server on master

2012-08-24 Thread Maja Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6753/ --- (Updated Aug. 24, 2012, 1:33 p.m.) Review request for giraph. Changes ---

Re: Review Request: Open Netty client and server on master

2012-08-24 Thread Maja Kabiljo
On Aug. 24, 2012, 7:51 a.m., Avery Ching wrote: This looks like a nice refactoring to handle different response for the master and workers. Looks like a great start to adding direct communication to the master. I have a few minor things below, but I think we shouldn't be removing

Re: Review Request: Open Netty client and server on master

2012-08-24 Thread Maja Kabiljo
On Aug. 24, 2012, 7:51 a.m., Avery Ching wrote: This looks like a nice refactoring to handle different response for the master and workers. Looks like a great start to adding direct communication to the master. I have a few minor things below, but I think we shouldn't be removing

Re: Review Request: Open Netty client and server on master

2012-08-24 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6753/#review10760 --- Everything looks fine, except the downcasting...would be great if we

Review Request: Open Netty client and server on master

2012-08-23 Thread Maja Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6753/ --- Review request for giraph. Description --- For GIRAPH-273 first thing we