jhsenjaliya commented on a change in pull request #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs URL: https://github.com/apache/incubator-gobblin/pull/2788#discussion_r341362631
########## File path: bin/gobblin.sh ########## @@ -283,18 +291,18 @@ elif [[ -f ${GOBBLIN_CONF}/log4j.properties ]]; then LOG4J_OPTS="-Dlog4j.configuration=$LOG4J_FILE_PATH" fi +#Create required directories if [[ ! -d "$GOBBLIN_LOGS" ]]; then mkdir -p $GOBBLIN_LOGS fi -GC_OPTS='' -if [[ ${ENABLE_GC_LOGS} -eq 1 ]]; then - GC_OPTS+="-XX:+UseConcMarkSweepGC -XX:+UseParNewGC -XX:+UseCompressedOops " - GC_OPTS+="-XX:+PrintGCDetails -XX:+PrintGCDateStamps -XX:+PrintTenuringDistribution " - GC_OPTS+="-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=$GOBBLIN_LOGS/ " - GC_OPTS+="-Xloggc:$GOBBLIN_LOGS/gobblin-$GOBBLIN_MODE-gc.log " +if [[ ! -d "$GOBBLIN_WORK_DIR" ]]; then + mkdir -p $GOBBLIN_WORK_DIR fi +if [[ ! -d "$GOBBLIN_JOB_CONFIG_DIR" ]]; then + mkdir -p $GOBBLIN_JOB_CONFIG_DIR +fi Review comment: do u mean if the change in env variables in `gobblin-env.sh` will get reflected and get dir created accordingly? yes. since `gobblin.sh` includes the `gobblin-env.sh`. I have added option to override it from user input as well, i think it will be useful to maintain any backward compatibility. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services