[GitHub] [incubator-gobblin] zxcware commented on issue #2846: [GOBBLIN-1001] Implement TimePartitionGlobFinder

2019-12-13 Thread GitBox
zxcware commented on issue #2846: [GOBBLIN-1001] Implement TimePartitionGlobFinder URL: https://github.com/apache/incubator-gobblin/pull/2846#issuecomment-565667972 @autumnust I generalized the finder which supports look back and will create a virtual partition dataset for any partition w

[GitHub] [incubator-gobblin] zxcware commented on issue #2846: [GOBBLIN-1001] Implement TimePartitionGlobFinder

2019-12-11 Thread GitBox
zxcware commented on issue #2846: [GOBBLIN-1001] Implement TimePartitionGlobFinder URL: https://github.com/apache/incubator-gobblin/pull/2846#issuecomment-564740742 @autumnust Yeah, `yesterdayPartition` is really specific, I'm thinking about generalize it to `enforcePreviousN`(looking for

[GitHub] [incubator-gobblin] zxcware commented on issue #2846: [GOBBLIN-1001] Implement TimePartitionGlobFinder

2019-12-10 Thread GitBox
zxcware commented on issue #2846: [GOBBLIN-1001] Implement TimePartitionGlobFinder URL: https://github.com/apache/incubator-gobblin/pull/2846#issuecomment-564333132 @autumnust It does use, compositely use instead of inheriting, an existing GlobFinder, which is `DefaultFileSystemGlobFinder