[ 
https://issues.apache.org/jira/browse/GORA-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052871#comment-14052871
 ] 

Moritz Hoffmann commented on GORA-346:
--------------------------------------

Hi [~lewismc], thanks for reviewing the patch! I just noticed that simply 
switching from jar building to bundle does not work, it seems more properties 
for OSGi need to be added. I'd be willing to read about this, but if you (or 
someone else) has more experience with this than please take this task - I've 
never dealt with bundle packaging before.

I totally agree that documentation is crucial for this patch as it introduces 
some complexity. I can do that: in what for do you like the documentation to be 
available? Readme, package javadoc etc.

For distribution I personally think only the gora-shims-distribution artifact 
should be distributed as it encapsulates the three other artifacts.

> Create shim layer to support multiple hadoop versions
> -----------------------------------------------------
>
>                 Key: GORA-346
>                 URL: https://issues.apache.org/jira/browse/GORA-346
>             Project: Apache Gora
>          Issue Type: Improvement
>    Affects Versions: 0.5
>            Reporter: Renato Javier MarroquĂ­n Mogrovejo
>            Assignee: Moritz Hoffmann
>              Labels: patch
>         Attachments: GORA-346_v1.patch, GORA-346_v2.patch, GORA-346_v3.patch, 
> GORA-346_v4_profiles.patch, GORA-346_v5.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to