Hi!
I don't understand the fix :S
getDirtyBytes was:
private ByteBuffer getDirtyBytes() {
return (ByteBuffer) get(0);
}
so, it was returning the content of the field __G__DIRTY(0, "__g__dirty"),
defined in the schema as type bytes.
Why exactly is needed to convert to string, etc?
Have y
Hi Alfonso,
The patch in GORA-326 has to be rebased as there are other fixes that have
come in before this one :( I will try to do that this week, but I wasn't
able to reproduce Lewis' error reported there.
GORA-326 aims to make dirty_bytes part of the class hierarchy instead of
copying the array
Hi, Renato.
I only meant if Lewis applied it to his local copy.
By the way, I am quite disconnected of GORA-326, but surely you can help me
:) where is the modified method "setDirty()"? How will be finally the
management of dirty values?
Thanks!
Alfonso Nishikawa
2014-08-05 11:05 GMT+02:00 R
I will try to :)
So GORA-189 is for fixing/alleviating the problems described there. It
doesn't have to do with the removal of the dirty_bytes array from the data
beans and compiler.
GORA-326 aimed to not to make this field (dirty bytes array) visible by the
users as some users could try modifying/
Hi, Renato.
I see. In my oppinion, the changes to the compiler and changes to
PersistentBase should be done in that issue. I find the title and
description incomplete.
"Removal of _g_dirty field from _ALL_FIELDS array and Field Enum in
Persistent classes" implies:
1* Define the method of state m
Thanks for the input Alfonso!
Yeah you are right about the title, but I just didn't want to make an issue
that was too big, but I will try to put everything and see if it is too big
or not and then we can all decide that to do with it :)
1. __g__dirty will still exist as a field but at the Persiste
[
https://issues.apache.org/jira/browse/GORA-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086163#comment-14086163
]
Alfonso Nishikawa commented on GORA-189:
I don't understand why it was throwing a Cl
[
https://issues.apache.org/jira/browse/GORA-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087003#comment-14087003
]
Lewis John McGibbney commented on GORA-326:
---
Can anyone else confirm this? I canno
[
https://issues.apache.org/jira/browse/GORA-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087023#comment-14087023
]
Lewis John McGibbney commented on GORA-363:
---
We should start compiling a collectio
Hi Alfonso,
On Tue, Aug 5, 2014 at 1:47 AM, wrote:
>
> I don't understand the fix :S
>
> The fix converts everything to ByteArray and not just simply casting the
value to ByteBuffer... which is illegal.
> getDirtyBytes was:
>
> private ByteBuffer getDirtyBytes() {
> return (ByteBuffer) ge
[
https://issues.apache.org/jira/browse/GORA-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lewis John McGibbney resolved GORA-364.
---
Resolution: Fixed
commit 89c025d2f9e4ba19378eb15537104c8775bf2474
Author: Lewis John Mc
[
https://issues.apache.org/jira/browse/GORA-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lewis John McGibbney closed GORA-364.
-
> MemStore.get fails with NPE when key is not set
> ---
[
https://issues.apache.org/jira/browse/GORA-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lewis John McGibbney updated GORA-364:
--
Assignee: Gerhard Gossen
> MemStore.get fails with NPE when key is not set
>
[
https://issues.apache.org/jira/browse/GORA-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lewis John McGibbney updated GORA-364:
--
Fix Version/s: 0.5
> MemStore.get fails with NPE when key is not set
> --
[
https://issues.apache.org/jira/browse/GORA-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087050#comment-14087050
]
Lewis John McGibbney commented on GORA-189:
---
The code for the Preview object as ab
[
https://issues.apache.org/jira/browse/GORA-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087155#comment-14087155
]
Hudson commented on GORA-364:
-
UNSTABLE: Integrated in gora-trunk #1165 (See
[https://builds.ap
[
https://issues.apache.org/jira/browse/GORA-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087173#comment-14087173
]
Lewis John McGibbney commented on GORA-189:
---
Can anyone else reproduce the ClassCa
[
https://issues.apache.org/jira/browse/GORA-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087171#comment-14087171
]
Lewis John McGibbney commented on GORA-189:
---
[~alfonso.nishikawa], the commit I ma
[
https://issues.apache.org/jira/browse/GORA-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087189#comment-14087189
]
Henry Saputra commented on GORA-189:
Hmm when I reviewed the patch it passed my local te
[
https://issues.apache.org/jira/browse/GORA-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087193#comment-14087193
]
Lewis John McGibbney commented on GORA-189:
---
Same here Henry. Same here.
> Embrac
[
https://issues.apache.org/jira/browse/GORA-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087209#comment-14087209
]
Lewis John McGibbney commented on GORA-266:
---
Hi [~sstults], thanks for reuploading
[
https://issues.apache.org/jira/browse/GORA-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087209#comment-14087209
]
Lewis John McGibbney edited comment on GORA-266 at 8/6/14 3:57 AM:
---
22 matches
Mail list logo
