[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-05 Thread GitBox
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480476838 I implemented the test. I also notice that in some places some keys are converted to `String` by default. I solved

Re: HBase test failure

2019-04-05 Thread Kevin Ratnasekera
Hi Lahiru, >From time to time, I am also noticing the same, however Jenkins build always get through as success. Thank you for bringing this up, currently I am looking into this issue, will get back to you with an update. Regards Kevin On Sat, Apr 6, 2019 at 10:37 AM Lahiru Jayasekera wrote:

[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-05 Thread GitBox
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480384094 So why don't you just create individual tests such as

[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-05 Thread GitBox
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480299253 Yes, I reviewed the `DataStoreTestBase`, but it creates a `employeeStore` and a `webPageStore` which both have String

[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-05 Thread GitBox
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480168630 @cuent you can easily implement individual tests for the module and use the `@Override` convention to implement the