Hi John.
Thanks for the feedback I will work on your comments.
Regards,
Gaby
El mié, 10 de feb. de 2021 a la(s) 12:04, John Mora (jhnmora...@gmail.com)
escribió:
> Hi Gaby
>
> Thanks for the update.
>
> BTW, I am sorry that I did not provide feedback on your code last week, I
> have been
Hi Gaby
Thanks for the update.
BTW, I am sorry that I did not provide feedback on your code last week, I
have been busy.
Some comments:
Please use more descriptive variable names:
Hi Maria
Thanks for the update.
Some comments:
Please use an Enum instead of literal strings for the Authentication Method
parameter.
https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/store/ElasticsearchStore.java#L126
Use
3 matches
Mail list logo