Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/88#discussion_r79923310
--- Diff:
gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ---
@@ -18,7 +18,7 @@
#if ($schema.getNamespace
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/88#discussion_r79947161
--- Diff:
gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ---
@@ -18,7 +18,7 @@
#if ($schema.getNamespace
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/88
Didn't know about that "magic" :) This evening I will push it :D Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/90
@lewismc I see the patch breaking older configurations when maybe we can
avoid it:
The method MongoCredential.createCredential() now does not work? If it
still works, it will be good to
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/90
@madhawa-gunasekara Great! Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/90
@lewismc Sorry! I have been much busy and ill after :( Thank you for the
merge.
Sorry!! :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/103
Hi!
I don't find necessary to have tests on this issue. The reason is that the
issue is about a wrong placed logging -the need to move it out of the `for`-,
so I don't fin
GitHub user alfonsonishikawa opened a pull request:
https://github.com/apache/gora/pull/105
GORA-511 Excluding package-info.java from test compile because m2e in
Eclipse â¦
â¦does not support duplicated package-info.java both in main and test.
You can merge this pull request
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/105
Here is the link to Jira https://issues.apache.org/jira/browse/GORA-511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user alfonsonishikawa opened a pull request:
https://github.com/apache/gora/pull/106
GORA-510 Conform Query.setEndKey to inclusive query for HBaseStore
Fix + enabled ignored Tests in HBase module.
Link to Jira: https://issues.apache.org/jira/browse/GORA-510
You can merge
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/103
If no one objects, I will commit this in a while :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/103
Commited, thank you very much, @nishadi .
@madhawa-gunasekara : What was happening is that it was showing one message
for each class not matching even when there were one class
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/109
@djkevincr , sure!
Looks good, test passes. I will merge in a while :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/109
Pushed. Thank you, @nishadi !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/95
I know this thread is old, but I don't understand why this not surfaced
before (the issue at HBase is from 2014). It seems that at HBase they will not
fix it until 2.0.0:
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/94
I tried locally too and can't reproduce the error.
I found this about your error:
https://issues.apache.org/jira/browse/CASSANDRA-8220
Seems related to OSX and JDK8.
GitHub user alfonsonishikawa opened a pull request:
https://github.com/apache/gora/pull/126
Setting dirty with value -1 (b) instead of -128(100b) wheâ¦
â¦n calling setDirty().
Omited tests since the change is trivial.
You can merge this pull request into a
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/126
Fix for GORA-421 https://issues.apache.org/jira/browse/GORA-421
---
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/126
For once I assumed it was too trivial for a test... ;)
I am working on it.
I noticed that maybe someone sometime would need a "setDirty" that sets
dirty d
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/126
Updated with the test :) Thanks for the feedback.
---
GitHub user alfonsonishikawa opened a pull request:
https://github.com/apache/gora/pull/127
GORA-530 : Reinstated exception throwing in DataStore and Query
https://issues.apache.org/jira/browse/GORA-530
This pull request reinstates exceptions throwing in DataStore and Query
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/127
Updated the pull request with a fix for a little bug I introduced.
AccumuloStore#deleteSchema() was failing when the table did not exist. Not does
not fail.
Thanks in advance for
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/127#discussion_r168014313
--- Diff:
gora-aerospike/src/main/java/org/apache/gora/aerospike/store/AerospikeStore.java
---
@@ -159,17 +167,25 @@ public boolean schemaExists
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/127#discussion_r171598778
--- Diff:
gora-aerospike/src/main/java/org/apache/gora/aerospike/store/AerospikeStore.java
---
@@ -159,17 +167,25 @@ public boolean schemaExists
GitHub user alfonsonishikawa opened a pull request:
https://github.com/apache/gora/pull/130
GORA-530: Removed redundant logging on several try/catch
Hi!
In this patch basically I removed the redundand "logging + throw" when the
log message is the same as in the
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/130
Done, thank you!
---
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/130
I can't believe how sausage-fingers I must be. I left a strange Eclipse
autoimport at
https://github.com/apache/gora/blob/master/gora-core/src/main/java/org/apache/gora/persistency
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r202935976
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java ---
@@ -0,0 +1,578 @@
+/**
+ * Licensed to the Apache
GitHub user alfonsonishikawa opened a pull request:
https://github.com/apache/gora/pull/135
Goraexplorer needed changes
This set of commits implements the following functionalities:
- Compile schemas from Strings and not only from files.
- Allow to configure the mapping
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r222505121
--- Diff: bin/compile-examples.sh ---
@@ -36,8 +36,57 @@ DIR=$GORA_HOME/$MODULE/src/examples/avro/
OUTDIR=$GORA_HOME/$MODULE/src/examples/java
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r222505739
--- Diff:
gora-compiler/src/main/java/org/apache/gora/compiler/GoraCompiler.java ---
@@ -86,6 +88,31 @@ public static void compileSchema(File
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r222506186
--- Diff:
gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ---
@@ -180,6 +180,11 @@ public class ${this.mangle
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r222506265
--- Diff: gora-core/src/examples/avro/employee.json ---
@@ -14,20 +14,22 @@
"name": "WebPage",
--- End diff --
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r222506447
--- Diff:
gora-core/src/main/java/org/apache/gora/mapreduce/GoraRecordWriter.java ---
@@ -76,4 +76,26 @@ public void write(K key, T value) throws
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r222507176
--- Diff:
gora-core/src/main/java/org/apache/gora/store/DataStoreMetadataFactory.java ---
@@ -0,0 +1,93 @@
+/**
--- End diff --
I
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r222507887
--- Diff:
gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java ---
@@ -80,15 +81,20 @@
* DataStore for HBase. Thread safe
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r222508076
--- Diff:
gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java ---
@@ -80,15 +81,20 @@
* DataStore for HBase. Thread safe
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r222508755
--- Diff: pom.xml ---
@@ -757,9 +758,9 @@
gora-maven-plugin
gora-mongodb
gora-solr
+gora-aerospike
--- End diff
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r222510709
--- Diff:
gora-pig/src/test/java/org/apache/gora/pig/GoraStorageTest.java-disabled ---
@@ -0,0 +1,352 @@
+package org.apache.gora.pig
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r224998986
--- Diff:
gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ---
@@ -180,6 +180,11 @@ public class ${this.mangle
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r224999854
--- Diff:
gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java ---
@@ -80,15 +81,20 @@
* DataStore for HBase. Thread safe
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r225000105
--- Diff: gora-pig/pom.xml ---
@@ -0,0 +1,180 @@
+
+http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r225000361
--- Diff:
gora-pig/src/main/java/org/apache/gora/pig/mapreduce/PigGoraOutputFormat.java
---
@@ -0,0 +1,86 @@
+package
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r225000854
--- Diff: gora-pig/src/test/examples/example.pig ---
@@ -0,0 +1,4 @@
+set job.name 'GoraStorage test' ;
+register gora/*.jar ;
Github user alfonsonishikawa commented on a diff in the pull request:
https://github.com/apache/gora/pull/135#discussion_r225001067
--- Diff: pom.xml ---
@@ -832,6 +833,12 @@
1.0.1
2.5
+
+0.16.0
+1.11-8
--- End diff
Github user alfonsonishikawa commented on the issue:
https://github.com/apache/gora/pull/136
Hi!
Will try to test it this weekend or maybe between this and next :S
I am deploying my server in my new flat and I have to install a
Goraexplorer VM (can't export dir
46 matches
Mail list logo
