GitHub user kamaci opened a pull request:
https://github.com/apache/gora/pull/43
GORA-439 Remove Unused Method Parameters
Unused method parameters are removed and API signatures made clean.
You can merge this pull request into a Git repository by running:
$ git pull https://git
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-145287775
I am in favour of this, but yeah we might discuss about the API some more
to see whether it makes sense to keep what. I mean right now, if those
parameters are not being
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-145281947
Hi @kamaci I had a look through the patch. Please make sure that there are
no regressions. I am +1 to commit if this is the case.
---
If your project is set up for it, you
Github user kamaci commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-145662887
Unused method parameters may lead a potential bug. Here is a list of what
I've changed:
* CassandraSuperColumn.java#getUnionIndex(String fieldName,
HColumn uc)
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-151674809
Hey @kamaci I think I will try to respond to myself lol I think it is fine
because the query object gets created by the dataStore, thus it will already
contain a refere
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-220396724
This has been merged right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user kamaci commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-220437423
I thought something is wrong but it is completely OK, no problem. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
8 matches
Mail list logo
