Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/48#issuecomment-170537424
but overall LGTM
maybe adding a new JIRA for testing the filter operation over gora-core
implementation? And thanks for doing this Lewis! great work!
---
If your
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/gora/pull/48#discussion_r49317117
--- Diff: gora-core/src/main/java/org/apache/gora/filter/FilterList.java ---
@@ -101,8 +109,25 @@ public void write(DataOutput out) throws IOException {
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/48#discussion_r49316977
--- Diff: gora-core/src/main/java/org/apache/gora/filter/FilterList.java ---
@@ -101,8 +109,25 @@ public void write(DataOutput out) throws IOException {
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/48#issuecomment-170564958
@renato2099 OK I updated the PR with the switch block which looks much
better. This is also updated and merged with master.
---
If your project is set up for it, you can
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/48#issuecomment-170584324
awesome @lewismc ! thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
6 matches
Mail list logo
