[GitHub] gora pull request: GORA-459

2016-01-18 Thread renato2099
Github user renato2099 commented on the pull request: https://github.com/apache/gora/pull/51#issuecomment-172539082 Can you commit this and the other PRs @lewismc please? I don't know why I don't have right to actually do the merging myself. Thanks man! --- If your project is set up

[GitHub] gora pull request: GORA-459

2016-01-18 Thread lewismc
Github user lewismc commented on the pull request: https://github.com/apache/gora/pull/51#issuecomment-172593992 Yeah I can but it would be good to sort the commit issue out. Are your trying to commit to the Git repos or the Github mirror? On Monday, January 18, 2016,

[GitHub] gora pull request: GORA-459

2016-01-18 Thread renato2099
Github user renato2099 commented on the pull request: https://github.com/apache/gora/pull/51#issuecomment-172681580 got it, then you wanna merge? or should I? :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] gora pull request: GORA-459

2016-01-18 Thread lewismc
Github user lewismc commented on the pull request: https://github.com/apache/gora/pull/51#issuecomment-172683094 If you can then please go ahead. I'm out and about now. I'll merge this into my HBase branch and submit a PR once it's ready. Thanks Renato. On Monday,

[GitHub] gora pull request: GORA-459

2016-01-18 Thread lewismc
Github user lewismc commented on the pull request: https://github.com/apache/gora/pull/51#issuecomment-172681318 Yeah it's all commits through the CLI to the canonical source at Apache. As the Github mirror is not canonical source, the merge functionality is disabled.

[GitHub] gora pull request: GORA-459

2016-01-18 Thread renato2099
Github user renato2099 commented on the pull request: https://github.com/apache/gora/pull/51#issuecomment-172680924 I can commit through the cmd line git commands, but I can't merge the PR from the github website, can you do that? or do you the commits directly from the cmd line?

[GitHub] gora pull request: GORA-459

2016-01-17 Thread lewismc
Github user lewismc commented on the pull request: https://github.com/apache/gora/pull/51#issuecomment-172417218 +1 On Sunday, January 17, 2016, Renato Marroquin wrote: > Fixing HBaseClusterSingleton.java unclosed resources returned from

[GitHub] gora pull request: GORA-459

2016-01-17 Thread renato2099
GitHub user renato2099 opened a pull request: https://github.com/apache/gora/pull/51 GORA-459 Fixing HBaseClusterSingleton.java unclosed resources returned from HBaseTestingUtility You can merge this pull request into a Git repository by running: $ git pull