+1 to merge!
I went quickly over the code and looks good to me. I think you guys already
commented the most pressing issues. Thanks!
Renato M.
2017-07-27 8:13 GMT-07:00 Furkan KAMACI :
> +1 to merge!
>
> On Wed, Jul 26, 2017 at 7:13 PM, Nishadi Kirielle <
> ndimeshi...@cse.mrt.ac.lk
> > wrote:
+1 to merge!
On Wed, Jul 26, 2017 at 7:13 PM, Nishadi Kirielle wrote:
> Thanks Kevin.
>
> I will create tickets for the remaining work.
>
> Regards
> Nishadi
>
> On 26 July 2017 at 21:08, Kevin Ratnasekera
> wrote:
>
>> Hi Lewis,
>>
>> Will do it Lewis, will wait others to comment if any case a
Thanks Kevin.
I will create tickets for the remaining work.
Regards
Nishadi
On 26 July 2017 at 21:08, Kevin Ratnasekera wrote:
> Hi Lewis,
>
> Will do it Lewis, will wait others to comment if any case as you said,
> otherwise will proceed merging to master.
>
> @Nishadi Can you please create t
Hi Lewis,
Will do it Lewis, will wait others to comment if any case as you said,
otherwise will proceed merging to master.
@Nishadi Can you please create tickets for the existing work? Forgot to
mention, this is very good work :)
Regards
Kevin
On Wed, Jul 26, 2017 at 8:55 PM, Nishadi Kirielle
Thanks a lot Lewis.
On 26 July 2017 at 20:54, lewis john mcgibbney wrote:
> Kevin or Furkan, if you could, please wait around 24 hours or so for any
> further code reviews and then go ahead and merge into master branch.
> Good work Nishadi, very good work.
>
> On Wed, Jul 26, 2017 at 8:19 AM, Ke
Kevin or Furkan, if you could, please wait around 24 hours or so for any
further code reviews and then go ahead and merge into master branch.
Good work Nishadi, very good work.
On Wed, Jul 26, 2017 at 8:19 AM, Kevin Ratnasekera
wrote:
> +1
>
> On Wed, Jul 26, 2017 at 8:48 PM, lewis john mcgibbne
+1
On Wed, Jul 26, 2017 at 8:48 PM, lewis john mcgibbney
wrote:
> Thnx for update. The code is looking pretty solid.
> Folks, what are you throughts on merging this into master branch? We can
> then create separate tickets for the following issues
>
>- The waiting strategy of the docker clie
Thnx for update. The code is looking pretty solid.
Folks, what are you throughts on merging this into master branch? We can
then create separate tickets for the following issues
- The waiting strategy of the docker client
- Incorporate the map reduce based test cases
- Improve the user do
Hi all,
As of the second evaluation period, I was able to implement most of the
possible functionality on gora-aerospike module.
Currently implemented features[1] include the follows;
- Basic PUT, GET, DELETE functionality
- Querying the whole set of data / querying on a single key
- De
9 matches
Mail list logo
