[GitHub] [gora] cuent commented on issue #186: [GORA-527] Implement Redis datastore

2019-11-12 Thread GitBox
cuent commented on issue #186: [GORA-527] Implement Redis datastore URL: https://github.com/apache/gora/pull/186#issuecomment-553015303 Hi, sorry, I haven't been with my laptop in almost the past month. I am just checking the status of the PR. Was it merged

[GitHub] [gora] djkevincr commented on issue #186: [GORA-527] Implement Redis datastore

2019-10-22 Thread GitBox
djkevincr commented on issue #186: [GORA-527] Implement Redis datastore URL: https://github.com/apache/gora/pull/186#issuecomment-544896356 There s updated PR available in https://github.com/apache/gora/pull/198 and merged. Hence closing the PR

[GitHub] [gora] djkevincr closed pull request #186: [GORA-527] Implement Redis datastore

2019-10-22 Thread GitBox
djkevincr closed pull request #186: [GORA-527] Implement Redis datastore URL: https://github.com/apache/gora/pull/186 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [gora] djkevincr merged pull request #198: [GORA-527] Redis Datastore

2019-10-22 Thread GitBox
djkevincr merged pull request #198: [GORA-527] Redis Datastore URL: https://github.com/apache/gora/pull/198 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [gora] djkevincr opened a new pull request #198: [GORA-527] Redis Datastore

2019-10-22 Thread GitBox
djkevincr opened a new pull request #198: [GORA-527] Redis Datastore URL: https://github.com/apache/gora/pull/198 Took over from https://github.com/apache/gora/pull/186 and resolved conflicts as well as test failures. Preserved commit history

[GitHub] [gora] djkevincr commented on issue #186: [GORA-527] Implement Redis datastore

2019-10-21 Thread GitBox
djkevincr commented on issue #186: [GORA-527] Implement Redis datastore URL: https://github.com/apache/gora/pull/186#issuecomment-544815187 @cuent Can you please resolve the conflicts? This is an automated message from

[GitHub] [gora] djkevincr commented on issue #186: [GORA-527] Implement Redis datastore

2019-09-14 Thread GitBox
djkevincr commented on issue #186: [GORA-527] Implement Redis datastore URL: https://github.com/apache/gora/pull/186#issuecomment-531488717 @cuent Can you please take up from master branch? This is an automated message from

[GitHub] [gora] djkevincr commented on issue #186: [GORA-527] Implement Redis datastore

2019-08-29 Thread GitBox
djkevincr commented on issue #186: [GORA-527] Implement Redis datastore URL: https://github.com/apache/gora/pull/186#issuecomment-526448022 @cuent Can you please take an update with current master? Your PR has conflicts

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement Redis datastore

2019-08-26 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement Redis datastore URL: https://github.com/apache/gora/pull/186#discussion_r317904794 ## File path: pom.xml ## @@ -845,7 +848,7 @@ 2.8.1 1.4 0.8 -3.1.1 +2.5.4 Review comment

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement Redis datastore

2019-08-26 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement Redis datastore URL: https://github.com/apache/gora/pull/186#discussion_r317904954 ## File path: pom.xml ## @@ -382,7 +382,7 @@ -posix

[GitHub] [gora] cuent commented on a change in pull request #186: [GORA-527] Implement Redis datastore

2019-08-22 Thread GitBox
cuent commented on a change in pull request #186: [GORA-527] Implement Redis datastore URL: https://github.com/apache/gora/pull/186#discussion_r316762082 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisResult.java ## @@ -0,0 +1,111

[GitHub] [gora] cuent commented on a change in pull request #186: [GORA-527] Implement Redis datastore

2019-08-22 Thread GitBox
cuent commented on a change in pull request #186: [GORA-527] Implement Redis datastore URL: https://github.com/apache/gora/pull/186#discussion_r316688662 ## File path: pom.xml ## @@ -1061,7 +1064,37 @@ ${flink.version} compile

[GitHub] [gora] cuent commented on a change in pull request #186: [GORA-527] Implement Redis datastore

2019-08-22 Thread GitBox
cuent commented on a change in pull request #186: [GORA-527] Implement Redis datastore URL: https://github.com/apache/gora/pull/186#discussion_r316685760 ## File path: pom.xml ## @@ -382,7 +382,7 @@ -posix

[GitHub] [gora] cuent commented on a change in pull request #186: [GORA-527] Implement Redis datastore

2019-08-22 Thread GitBox
cuent commented on a change in pull request #186: [GORA-527] Implement Redis datastore URL: https://github.com/apache/gora/pull/186#discussion_r316684886 ## File path: pom.xml ## @@ -382,7 +382,7 @@ -posix

[GitHub] [gora] cuent commented on a change in pull request #186: [GORA-527] Implement Redis datastore

2019-08-22 Thread GitBox
cuent commented on a change in pull request #186: [GORA-527] Implement Redis datastore URL: https://github.com/apache/gora/pull/186#discussion_r316684736 ## File path: pom.xml ## @@ -845,7 +848,7 @@ 2.8.1 1.4 0.8 -3.1.1 +2.5.4 Review comment

Re: Redis datastore

2019-06-18 Thread FRANCISCO XAVIER SUMBA TORAL
Thanks Carlos. I will look into aerospike and update the question to the report. Best, Xavier. On Mon, Jun 17, 2019, 11:26 PM carlos muñoz, wrote: > Hi Xavier, > > IMHO, it would be okay to ignore these methods, this case is similar to > Aerospike, give a look to [1]. Also, you may have to

Re: Redis datastore

2019-06-17 Thread carlos muñoz
Hi Xavier, IMHO, it would be okay to ignore these methods, this case is similar to Aerospike, give a look to [1]. Also, you may have to ignore the schema related tests[2]. [1]

Re: Redis datastore

2019-06-16 Thread FRANCISCO XAVIER SUMBA TORAL
Hello Madhawa, Thanks for your comment. Yeah, I will address that this week. And I have a question: Redis doesn't have a schema as other data stores, so is it okay to leave functions such as createSchema, deleteSchema y schemaExists with no implementation? Best, Xavier. > On Jun 15, 2019,

Re: Redis datastore

2019-06-15 Thread Madhawa Kasun Gunasekara
Hi Xavier, You should consider other data types also, not only Hashes. [1] Sometimes users like to store data in String data type as well. Please check on that as well [1] https://redis.io/topics/data-types Thanks, Madhawa On Sat, Jun 15, 2019 at 8:20 PM FRANCISCO XAVIER SUMBA TORAL wrote:

Re: Redis datastore

2019-06-15 Thread FRANCISCO XAVIER SUMBA TORAL
Hello, My weekly report is updated on the wiki. Also, I moved all the code from master the branch GORA-527. And did the following tasks. Port to test containers (Docker redis) Add connections mode configuration (cluster, replicated, …) Implement put, exists, get, delete Fix Alfonso comments

Re: Redis datastore

2019-06-10 Thread FRANCISCO XAVIER SUMBA TORAL
Thanks Alonso for your comments. I will analyze the code from HBase. Thanks for your suggestion… Also, my code is in master, but I will move to the branch 527, it will be easier to trace changes. Best, Xavier. > On Jun 10, 2019, at 18:20, Alfonso Nishikawa > wrote: > > Hi, Xavier. > >

Re: Redis datastore

2019-06-10 Thread Alfonso Nishikawa
Hi, Xavier. I don't see your branch GORA-527 told in your report. What I would want to ask for is to add the same functionality to load the mapping from configuration in you RedisStore [1] as in HBase's store [2]. This will have implications on your readMapping that in HBase was done by passing

Re: Redis datastore

2019-06-09 Thread FRANCISCO XAVIER SUMBA TORAL
Thanks for your comments. I pushed my commits and updated the report. During this week I want to decide what redisson codec works best for gora’s use case and I will also solve the comments of the libraries comparison. I will keep updating you guys during the week any blocker or new tasks

Re: Redis datastore

2019-06-09 Thread carlos muñoz
Hi Xavier The document looks great. I have left a few comments. I would like to read other valorations . Also, please make sure to publish your weekly process on the Wiki space. Regards, Carlos El vie., 7 jun. 2019 a las 23:01, FRANCISCO XAVIER SUMBA TORAL () escribió: > Sorry, try again.

Re: Redis datastore

2019-06-07 Thread FRANCISCO XAVIER SUMBA TORAL
Sorry, try again. Anybody should be able to access? I set for everyone. https://docs.google.com/document/d/17RlGIu_SaPo7O2J7k_htg1UDDO9ah41u8cCYUURC7BM/edit?usp=sharing Best, Xavier > On Jun 7, 2019, at 23:59, Kevin Ratnasekera wrote: > > Hi Xavier, > > I requested access to the docs. Can

Re: Redis datastore

2019-06-07 Thread Kevin Ratnasekera
Hi Xavier, I requested access to the docs. Can you please give permissions? Regards Kevin On Sat, Jun 8, 2019 at 9:23 AM FRANCISCO XAVIER SUMBA TORAL wrote: > Hello > > I think that redisson is the option to support redis in gora. > > There is an analysis here [1]. What do you think? After

Re: Redis datastore

2019-06-07 Thread FRANCISCO XAVIER SUMBA TORAL
Hello I think that redisson is the option to support redis in gora. There is an analysis here [1]. What do you think? After some suggestions I can add those results to the wiki. Best Xavier [1] https://docs.google.com/document/d/17RlGIu_SaPo7O2J7k_htg1UDDO9ah41u8cCYUURC7BM/edit?usp=drivesdk

Re: Redis datastore

2019-06-05 Thread FRANCISCO XAVIER SUMBA TORAL
On Wed, Jun 5, 2019, 1:31 AM Kevin Ratnasekera, wrote: > Hi Xavier, > > Thank you for the update. Take your time on the research for selecting the > Redis client library, you dont need to compare all Redis clients, take a > subset/few looks most promising ( by comparing community, functionality

Re: Redis datastore

2019-06-04 Thread Kevin Ratnasekera
Hi Xavier, Thank you for the update. Take your time on the research for selecting the Redis client library, you dont need to compare all Redis clients, take a subset/few looks most promising ( by comparing community, functionality etc ). There are only very few recommended from redis.io. [1] (

Re: Redis datastore

2019-06-04 Thread FRANCISCO XAVIER SUMBA TORAL
Hello, About trying other libraries, it is a broad task. There are a lot and each of them has its own advantage/disadvantage. Redisson, looks promising and think we can use that one instead of Jedis, but I am still comparing with other libraries. I will get back with this comparison soon.

Re: Redis datastore

2019-06-04 Thread carlos muñoz
Hi Xavier. Please note that redis-mock has some limitations. Alternatively, If you realize that you need unsupported operations you can use docker, give a look to the Aerospike tests [2]. my two cents, [1] https://github.com/fppt/jedis-mock#supported-operations [2]

Re: Redis datastore

2019-06-03 Thread Madhawa Kasun Gunasekara
Hi Xavier, It's better to do an analysis of Redis clients. then based on the results, we can choose what is the appropriate library for the implementation. Please update this mail thread weekly about your project progress. Mainly you can update what you have done for the week and what you are

Re: Redis datastore

2019-05-27 Thread Kevin Ratnasekera
Hi Xavier, Please find my answers inline. On Mon, May 27, 2019 at 10:33 AM FRANCISCO XAVIER SUMBA TORAL wrote: > Hello, > > I am using Jedis Mock [1] to embed Redis for tests. However, I am > wondering since redis accepts master/slave cluster / replication / no > replication / single instance.

Re: GSoC proposal for Redis Datastore

2019-04-08 Thread Xavier Sumba
Hi Kevin and Madhawa, Thanks so much for your comments. I will address them today and make the final submission. Thanks all of your for your help guys! Best, Xavier. > On Apr 8, 2019, at 12:26, Kevin Ratnasekera wrote: > > Hi Xavier, > > The proposal you come up with looks very good.

Re: GSoC proposal for Redis Datastore

2019-04-08 Thread Kevin Ratnasekera
Hi Xavier, The proposal you come up with looks very good. Added some comment on the proposal. Please address before the final submission. Good luck with your submission. Regards Kevin On Mon, Apr 8, 2019 at 9:44 PM Madhawa Kasun Gunasekara wrote: > Hi Xavier. > > Overall, The proposal looks

Re: GSoC proposal for Redis Datastore

2019-04-08 Thread Madhawa Kasun Gunasekara
Hi Xavier. Overall, The proposal looks good. I added some comments. Good Luck. Madhawa On Sat, Apr 6, 2019 at 10:09 PM Xavier Sumba wrote: > Hi Carlos, > > Thanks so much for your suggestions. I already made the changes. > > Best, > Xavier. > > > On Apr 6, 2019, at 15:19, carlos muñoz

Re: GSoC proposal for Redis Datastore

2019-04-06 Thread Xavier Sumba
Hi Carlos, Thanks so much for your suggestions. I already made the changes. Best, Xavier. > On Apr 6, 2019, at 15:19, carlos muñoz wrote: > > Hi Xavier. > > The proposal is looking really good. I added some minor comments. > > Good Luck. > > Regards, > Carlos > > El sáb., 6 abr. 2019 a

Re: GSoC proposal for Redis Datastore

2019-04-06 Thread carlos muñoz
Hi Xavier. The proposal is looking really good. I added some minor comments. Good Luck. Regards, Carlos El sáb., 6 abr. 2019 a las 12:43, Xavier Sumba () escribió: > Hello, > > As discussed in Jira, I would like to participate in GSoC 2019. I have > been through a lot with finals and projects

GSoC proposal for Redis Datastore

2019-04-06 Thread Xavier Sumba
Hello, As discussed in Jira, I would like to participate in GSoC 2019. I have been through a lot with finals and projects but I managed to write my proposal and work in a small issue. Specifically, I want to work in the support of Redis DB to Gora [1]. I also worked in the range queries for