[GitHub] incubator-griffin pull request #319: Topics/refactor_ut

2018-06-20 Thread evanwan87
GitHub user evanwan87 opened a pull request: https://github.com/apache/incubator-griffin/pull/319 Topics/refactor_ut You can merge this pull request into a Git repository by running: $ git pull https://github.com/evanwan87/incubator-griffin topics/ut Alternatively you can

[jira] [Commented] (GRIFFIN-107) [UI] - DataAsset register including HDFS and Kafka

2018-06-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518828#comment-16518828 ] ASF GitHub Bot commented on GRIFFIN-107: Github user asfgit closed the pull request at:

[GitHub] incubator-griffin pull request #242: JIRA-GRIFFIN-107-UI-add hdfs data...

2018-06-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-griffin/pull/242 ---

[GitHub] incubator-griffin pull request #125: Add kafka topics

2018-06-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-griffin/pull/125 ---

[GitHub] incubator-griffin pull request #241: wash up: SparkSubmitJobTest

2018-06-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-griffin/pull/241 ---

[GitHub] incubator-griffin pull request #318: This closes #125

2018-06-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-griffin/pull/318 ---

[GitHub] incubator-griffin pull request #318: This closes #125

2018-06-20 Thread guoyuepeng
GitHub user guoyuepeng opened a pull request: https://github.com/apache/incubator-griffin/pull/318 This closes #125 at the same time, we will close some obsolete PRs. This closes #125 This closes #241 THis closes #242 This closes #279 You can merge this pull

[GitHub] incubator-griffin pull request #316: update scala maven plugin to lastest ve...

2018-06-20 Thread toyboxman
Github user toyboxman closed the pull request at: https://github.com/apache/incubator-griffin/pull/316 ---

[GitHub] incubator-griffin issue #316: update scala maven plugin to lastest verson

2018-06-20 Thread guoyuepeng
Github user guoyuepeng commented on the issue: https://github.com/apache/incubator-griffin/pull/316 hi for compatible, we need scala-maven-plugin as 3.3.1 Thanks, William ---

[GitHub] incubator-griffin issue #316: update scala maven plugin to lastest verson

2018-06-20 Thread toyboxman
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/316 sure, you are right. I'm using maven 3.5.3. I have changed to 3.4.1 in latest update, pls review again ---

[GitHub] incubator-griffin issue #316: update scala maven plugin to lastest verson

2018-06-20 Thread bhlx3lyx7
Github user bhlx3lyx7 commented on the issue: https://github.com/apache/incubator-griffin/pull/316 Hi @toyboxman , thanks for you PR, but it didn't pass the CI build. I've checked about this, for the scala-maven-plugin, 3.4.1 requires maven 3.5.3, but in CI the maven version is

[GitHub] incubator-griffin pull request #317: Refactor/update cases

2018-06-20 Thread toyboxman
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/317 Refactor/update cases refactor JsonUtilTest codes including: 1.remove unusual assert keyword instead of Assert 2.trim and clean codes You can merge this pull request into

[GitHub] incubator-griffin pull request #316: update scala maven plugin to lastest ve...

2018-06-20 Thread toyboxman
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/316 update scala maven plugin to lastest verson as I hit maven build error like below, I check pom build file and find scala-maven-plugin is a bit old, so I make a change to refresh.