[GitHub] incubator-griffin pull request #320: refactor job structure to remove redund...

GitHub user ahutsunshine opened a pull request: https://github.com/apache/incubator-griffin/pull/320 refactor job structure to remove redundant class and api 1.refactor job structure 2.remove JobSchedule class to make job structure more clear 3.remove JobDataBean to make resp

[GitHub] incubator-griffin pull request #321: rename spark.url to resource manager ur...

GitHub user jasonliaoxiaoge opened a pull request: https://github.com/apache/incubator-griffin/pull/321 rename spark.url to resource manager url and log exception stack tree rename spark.url to resource manager url and log exception stack tree You can merge this pull request into a

[GitHub] incubator-griffin pull request #319: Topics/refactor_ut

Github user asfgit closed the pull request at: https://github.com/apache/incubator-griffin/pull/319 ---

[GitHub] incubator-griffin issue #321: rename spark.url to resource manager url and l...

Github user guoyuepeng commented on the issue: https://github.com/apache/incubator-griffin/pull/321 LGTM. ---

[GitHub] incubator-griffin issue #320: refactor job structure to remove redundant cla...

Github user guoyuepeng commented on the issue: https://github.com/apache/incubator-griffin/pull/320 hi Yao, there are some conflicting files, could you fix them then we will review this patch. Thanks, William ---

[GitHub] incubator-griffin pull request #322: Refactor/update cases

GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/322 Refactor/update cases You can merge this pull request into a Git repository by running: $ git pull https://github.com/toyboxman/incubator-griffin refactor/update-cases Alternati

[GitHub] incubator-griffin pull request #322: Refactor/update cases

Github user toyboxman closed the pull request at: https://github.com/apache/incubator-griffin/pull/322 ---

[jira] [Commented] (GRIFFIN-114) [Service][UT] Enhance unit test of config, info, util in service module

[ https://issues.apache.org/jira/browse/GRIFFIN-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519898#comment-16519898 ] wanyin commented on GRIFFIN-114: Sent the PR: https://github.com/apache/incubator-griffi

[GitHub] incubator-griffin pull request #323: refactor test codes in service/src/test...

GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/323 refactor test codes in service/src/test/java/org/apache/griffin/core/… …util/PropertiesUtilTest.java 1.remove assert keyword instead of Junit Assert class You can merge thi

[GitHub] incubator-griffin issue #321: rename spark.url to resource manager url and l...

Github user guoyuepeng commented on the issue: https://github.com/apache/incubator-griffin/pull/321 rename spark to resource manager is a good proposal, but rm always remind me the remove command, maybe we need to use full name as 'resource.manager', that makes things clear.

[GitHub] incubator-griffin issue #321: rename spark.url to resource manager url and l...

Github user jasonliaoxiaoge commented on the issue: https://github.com/apache/incubator-griffin/pull/321 Done, change to yarn url ---

[GitHub] incubator-griffin pull request #323: refactor test codes in service/src/test...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-griffin/pull/323 ---

[GitHub] incubator-griffin issue #320: refactor job structure to remove redundant cla...

Github user ahutsunshine commented on the issue: https://github.com/apache/incubator-griffin/pull/320 hi @guoyuepeng ， I have solved conflicting files. If you have time, pls review this pr. Thanks, Kevin Yao ---