[GitHub] incubator-griffin issue #332: fix a bad practice

2018-07-02 Thread whhe
Github user whhe commented on the issue: https://github.com/apache/incubator-griffin/pull/332 Hi @toyboxman Thanks for your advice, but I think the line separator here has nothing to do with platform. Elasticsearch just use it (in http entity) to identify the bulk request

[GitHub] incubator-griffin issue #331: refactor dead test cases

2018-07-02 Thread toyboxman
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/331 I don't touch those testcases, just add some test cases for kafka service. I need to check it later ---

[GitHub] incubator-griffin pull request #332: fix a bad practice

2018-07-02 Thread toyboxman
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/332 fix a bad practice Format string should use %n rather than \n In format strings, it is generally preferable better to use %n, which will produce the platform-specific line

[GitHub] incubator-griffin issue #331: refactor dead test cases

2018-07-02 Thread guoyuepeng
Github user guoyuepeng commented on the issue: https://github.com/apache/incubator-griffin/pull/331 hi Jin, Could you check why build failed? Tests in error: JobInstanceBeanRepoTest.testFindByActiveState » IllegalState Failed to load Ap...

[GitHub] incubator-griffin pull request #331: refactor dead test cases

2018-07-02 Thread toyboxman
GitHub user toyboxman opened a pull request: https://github.com/apache/incubator-griffin/pull/331 refactor dead test cases 1.active KafkaSchemaServiceImplTest and resolve failures You can merge this pull request into a Git repository by running: $ git pull