[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647548#comment-16647548 ] ASF GitHub Bot commented on GRIFFIN-206: Github user ahutsunshine commented on t

[GitHub] incubator-griffin issue #435: [GRIFFIN-206] fix job timezone when creating f...

2018-10-11 Thread ahutsunshine
Github user ahutsunshine commented on the issue: https://github.com/apache/incubator-griffin/pull/435 @chemikadze You are right. In backend, the method of getTimeZone always returns GMT timezone for UTC-1 or UTC+01:00 or other similar formats, as the given timezone ID cannot be

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

2018-10-11 Thread chemikadze
Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224622868 --- Diff: measure/src/main/scala/org/apache/griffin/measure/configuration/dqdefinition/DQConfig.scala --- @@ -148,12 +148,12 @@ case class Eva

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647108#comment-16647108 ] ASF GitHub Bot commented on GRIFFIN-206: Github user chemikadze commented on a d

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread chemikadze
Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224622499 --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts --- @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit, Aft

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647096#comment-16647096 ] ASF GitHub Bot commented on GRIFFIN-206: Github user chemikadze commented on a d

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread chemikadze
Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224620459 --- Diff: ui/angular/src/app/measure/create-measure/configuration/configuration.component.ts --- @@ -56,47 +56,47 @@ export class Configuratio

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread gavlyukovskiy
Github user gavlyukovskiy commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224560857 --- Diff: service/src/test/java/org/apache/griffin/core/util/TimeUtilTest.java --- @@ -110,4 +111,36 @@ public void testFormatWithIllegalExc

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646880#comment-16646880 ] ASF GitHub Bot commented on GRIFFIN-206: Github user gavlyukovskiy commented on

GRIFFIN-205 split on 2 tickets

2018-10-11 Thread Artem Shutak
Hello all, In process of working on https://issues.apache.org/jira/browse/GRIFFIN-205 I'v implemented a patch for "batch" dq type. Now I see at least 2 options: - Apply the patch as is and create separate ticket for "streaming" dq type. As an advantage here we will improve "batch" dq type as soon

RE: Metrics not persisted when writing a query in SPARK-SQL insteadof Griffin DSL

2018-10-11 Thread Lionel, Liu
That’s cool! Thanks Lionel, Liu From: Vikram Jain Sent: 2018年10月11日 22:52 To: Lionel Liu Cc: dev@griffin.incubator.apache.org Subject: Re: Metrics not persisted when writing a query in SPARK-SQL insteadof Griffin DSL Thank you Lionel for your help.  We figured it out just before your mail arriv

[GitHub] incubator-griffin pull request #436: always use apache griffin together as o...

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/436#discussion_r224487868 --- Diff: griffin-doc/dev/dev-env-build.md --- @@ -85,7 +85,7 @@ mvn clean install ``` ### For service module and ui module -

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

2018-10-11 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224486025 --- Diff: measure/src/main/scala/org/apache/griffin/measure/configuration/dqdefinition/DQConfig.scala --- @@ -74,9 +74,9 @@ case class DQConfi

[GitHub] incubator-griffin pull request #436: always use apache griffin together as o...

2018-10-11 Thread guoyuepeng
GitHub user guoyuepeng opened a pull request: https://github.com/apache/incubator-griffin/pull/436 always use apache griffin together as our mark You can merge this pull request into a Git repository by running: $ git pull https://github.com/guoyuepeng/incubator-griffin use_a

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646548#comment-16646548 ] ASF GitHub Bot commented on GRIFFIN-206: Github user ashutakGG commented on a di

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224482419 --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts --- @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit, Afte

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646543#comment-16646543 ] ASF GitHub Bot commented on GRIFFIN-206: Github user ashutakGG commented on a di

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646542#comment-16646542 ] ASF GitHub Bot commented on GRIFFIN-206: Github user ashutakGG commented on a di

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646540#comment-16646540 ] ASF GitHub Bot commented on GRIFFIN-206: Github user ashutakGG commented on a di

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646541#comment-16646541 ] ASF GitHub Bot commented on GRIFFIN-206: Github user ashutakGG commented on a di

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646539#comment-16646539 ] ASF GitHub Bot commented on GRIFFIN-206: Github user ashutakGG commented on a di

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224461843 --- Diff: service/src/test/java/org/apache/griffin/core/util/TimeUtilTest.java --- @@ -110,4 +111,36 @@ public void testFormatWithIllegalExcepti

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224461713 --- Diff: service/src/test/java/org/apache/griffin/core/util/TimeUtilTest.java --- @@ -110,4 +111,36 @@ public void testFormatWithIllegalExcepti

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224459867 --- Diff: service/src/test/java/org/apache/griffin/core/util/TimeUtilTest.java --- @@ -110,4 +111,36 @@ public void testFormatWithIllegalExcepti

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224481345 --- Diff: ui/angular/src/app/measure/create-measure/configuration/configuration.component.ts --- @@ -56,47 +56,47 @@ export class Configuration

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224479994 --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts --- @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit, Afte

Re: Metrics not persisted when writing a query in SPARK-SQL instead of Griffin DSL

2018-10-11 Thread Vikram Jain
Thank you Lionel for your help. We figured it out just before your mail arrived :) Regards, Vikram > On 11-Oct-2018, at 8:20 PM, Lionel Liu wrote: > > > Hi Vikram, > > In your JSON body, I notice that in the "rules" field, there's no "out" > field, which means griffin measure application

Re:Metrics not persisted when writing a query in SPARK-SQL instead of Griffin DSL

2018-10-11 Thread Lionel Liu
Hi Vikram, In your JSON body, I notice that in the "rules" field, there's no "out" field, which means griffin measure application will only calculate without output. You might just changed the "dsl.type" from "griffin-dsl" to "spark-sql", actually, for a "griffin-dsl" rule with "dq.type" as

Re: Metrics not persisted when writing a query in SPARK-SQL instead of Griffin DSL

2018-10-11 Thread William Guo
hi Vikram, Could you tell us which apache griffin version are you using? Could you show us your env.json also? please check this document http://griffin.incubator.apache.org/docs/profiling.html Thanks, William On Thu, Oct 11, 2018 at 6:30 PM Vikram Jain wrote: > Hello, > > I was trying to cr

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224438517 --- Diff: measure/src/test/scala/org/apache/griffin/measure/transformations/AccuracyTransformationsIntegrationTest.scala --- @@ -0,0 +1,169 @@

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224432819 --- Diff: measure/src/main/scala/org/apache/griffin/measure/configuration/dqdefinition/DQConfig.scala --- @@ -148,12 +148,12 @@ case class Eval

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224431040 --- Diff: measure/src/main/scala/org/apache/griffin/measure/configuration/dqdefinition/DQConfig.scala --- @@ -74,9 +74,9 @@ case class DQConfig

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224425167 --- Diff: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala --- @@ -125,14 +126,26 @@ cas

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

2018-10-11 Thread ashutakGG
Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224424475 --- Diff: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala --- @@ -125,14 +126,26 @@ cas

Metrics not persisted when writing a query in SPARK-SQL instead of Griffin DSL

2018-10-11 Thread Vikram Jain
Hello, I was trying to create a measure and write the rule in Spark-SQL directly instead of Griffin-DSL. I use Postman to create the measure. The measure is created successfully, the job is created and executed successfully. However, the output metrics of execution of jobs are not persisted in

Re: [DISCUSS] Graduate Apache Griffin (incubating) as a TLP

2018-10-11 Thread 亮 邵
+1 agree to gradate as TLP. the community has been very actively contributing this software as a kind of unique solution for data quality. it has benefits to users and members are gained a lot of experiences on Apache way. thanks. From: john@apache Sent: Wednes