[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-13 Thread ahutsunshine
Github user ahutsunshine commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224951998 --- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java --- @@ -148,4 +149,11 @@ private static String refreshEscapeHashTa

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648788#comment-16648788 ] ASF GitHub Bot commented on GRIFFIN-206: Github user ahutsunshine commented on a

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648789#comment-16648789 ] ASF GitHub Bot commented on GRIFFIN-206: Github user chemikadze commented on a d

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-13 Thread chemikadze
Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224952112 --- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java --- @@ -148,4 +149,11 @@ private static String refreshEscapeHashTag(

Re: [VOTE] Graduate Apache Griffin (incubating) as a TLP

2018-10-13 Thread He Wang
+1 On Fri, Oct 12, 2018 at 5:39 PM William Guo wrote: > hi all, > > Please vote on the proposal for Apache Griffin graduation to TLP to submit > to > the Incubator PMC. > > Vote: > [ ] +1 - Recommend Graduation of Apache Griffin as a TLP > [ ] -1 - Do not recommend graduation of Apache Griffin b

Re: [VOTE] Graduate Apache Griffin (incubating) as a TLP

2018-10-13 Thread Raju Goud
+1 On Sat, 13 Oct 2018 at 13:49, He Wang wrote: > +1 > > On Fri, Oct 12, 2018 at 5:39 PM William Guo wrote: > > > hi all, > > > > Please vote on the proposal for Apache Griffin graduation to TLP to > submit > > to > > the Incubator PMC. > > > > Vote: > > [ ] +1 - Recommend Graduation of Apache

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-13 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224948342 --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts --- @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit, Aft

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648864#comment-16648864 ] ASF GitHub Bot commented on GRIFFIN-206: Github user guoyuepeng commented on a d

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-13 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224955984 --- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java --- @@ -148,4 +149,11 @@ private static String refreshEscapeHashTag(

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648866#comment-16648866 ] ASF GitHub Bot commented on GRIFFIN-206: Github user guoyuepeng commented on a d

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-13 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224956283 --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts --- @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit, Aft

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648873#comment-16648873 ] ASF GitHub Bot commented on GRIFFIN-206: Github user guoyuepeng commented on a d

[GitHub] incubator-griffin pull request #432: Fix a little doc bug concerning measure...

2018-10-13 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/432#discussion_r224948476 --- Diff: griffin-doc/measure/measure-streaming-sample.md --- @@ -18,7 +18,7 @@ under the License. --> # Measure Streaming Sampl

[GitHub] incubator-griffin pull request #432: Fix a little doc bug concerning measure...

2018-10-13 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/432#discussion_r224948471 --- Diff: griffin-doc/measure/measure-batch-sample.md --- @@ -18,7 +18,7 @@ under the License. --> # Measure Batch Sample -M

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

2018-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-griffin/pull/434 ---

[jira] [Commented] (GRIFFIN-205) Accuracy measure check should provide matchedFraction to store

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648874#comment-16648874 ] ASF GitHub Bot commented on GRIFFIN-205: Github user asfgit closed the pull requ

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

2018-10-13 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224956533 --- Diff: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala --- @@ -125,14 +126,20 @@ ca

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

2018-10-13 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224956554 --- Diff: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala --- @@ -125,14 +126,20 @@ ca

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

2018-10-13 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224956565 --- Diff: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala --- @@ -125,14 +126,20 @@ ca

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

2018-10-13 Thread bhlx3lyx7
Github user bhlx3lyx7 commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224957455 --- Diff: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala --- @@ -125,14 +126,20 @@ cas

[jira] [Commented] (GRIFFIN-205) Accuracy measure check should provide matchedFraction to store

2018-10-13 Thread Lionel Liu (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648899#comment-16648899 ] Lionel Liu commented on GRIFFIN-205: In my opinion, the "total", "miss" and "matched

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-13 Thread chemikadze
Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224970940 --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts --- @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit, Aft

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649102#comment-16649102 ] ASF GitHub Bot commented on GRIFFIN-206: Github user chemikadze commented on a d

Re: [jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-13 Thread William Guo
don't worry, we can do it in angular side. On Sun, Oct 14, 2018 at 4:17 AM ASF GitHub Bot (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649102#comment-16649102 > ] > > ASF GitHu

[GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...

2018-10-13 Thread chemikadze
Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/435#discussion_r224981272 --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts --- @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit, Aft

[jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI

2018-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649274#comment-16649274 ] ASF GitHub Bot commented on GRIFFIN-206: Github user chemikadze commented on a d