[GitHub] incubator-griffin issue #384: Initialize java code checks rules for griffin

2018-08-21 Thread toyboxman
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/384 @guoyuepeng I append guide part about how to enable style-check in maven and idea. I think we can add scala and type script code style rule here as well thanks ---

[GitHub] incubator-griffin issue #384: Initialize java code checks rules for griffin

2018-08-09 Thread toyboxman
Github user toyboxman commented on the issue: https://github.com/apache/incubator-griffin/pull/384 I agree with you @guoyuepeng actually a code style guide is better than code template here. I will revise this patch ---

[GitHub] incubator-griffin issue #384: Initialize java code checks rules for griffin

2018-08-07 Thread guoyuepeng
Github user guoyuepeng commented on the issue: https://github.com/apache/incubator-griffin/pull/384 @toyboxman ---