Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/388
@guoyuepeng
William,
I see recent changes still have some violations against basic code style
rules. like import statement using * instead of concrete class name, too long
code
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/388
conflicts have been resolved
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/388
@guoyuepeng
William,
I'll resolve those conflicts. any question, let me know
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/388
@toyboxman
hi Jin,
There are some conflicts, could you try to sync it and submit the PR again?
Thanks,
William
---
