Re: groovy git commit: Fixing squid:S2444 - Lazy initialization of "static" fields should be "synchronized"

2016-01-05 Thread Pascal Schumacher
No need to apologize. It's good that you review changes and point out potential problems. :) Thanks! Am 06.01.2016 um 00:27 schrieb John Wagenleitner: My mistake, I didn't know there was a PR associated that Jochen had already reviewed. Sorry about that. On Tue, Jan 5, 2016 at 2:45 PM, Pasc

Re: groovy git commit: Fixing squid:S2444 - Lazy initialization of "static" fields should be "synchronized"

2016-01-05 Thread John Wagenleitner
My mistake, I didn't know there was a PR associated that Jochen had already reviewed. Sorry about that. On Tue, Jan 5, 2016 at 2:45 PM, Pascal Schumacher wrote: > Yes, I agree the change most likely reduces performance, but increases > thread-safety (prevent that different Threads may work wit

Re: groovy git commit: Fixing squid:S2444 - Lazy initialization of "static" fields should be "synchronized"

2016-01-05 Thread Pascal Schumacher
Yes, I agree the change most likely reduces performance, but increases thread-safety (prevent that different Threads may work with different Metaclasses etc.) I do not know enough about this area of the code to judge if the lack of thread-safety is really a concern. I just merged the pull r

Re: groovy git commit: Fixing squid:S2444 - Lazy initialization of "static" fields should be "synchronized"

2016-01-05 Thread John Wagenleitner
Not sure but wonder if HandleMetaClass#myMetaClass was static to avoid having to perform a lookup for each HMC instance. Probably not a issue but thought I'd bring attention to it. On Tue, Jan 5, 2016 at 10:13 AM, wrote: > Repository: groovy > Updated Branches: > refs/heads/master 586a316da -

Re: Release 2.4.6 and 2.5.0-beta?

2016-01-05 Thread jim northrop
1. Have done another doc upload. Spent time getting all the *.jar and *.zip files from gpars.org to include here: http://gparsdocs.de.a9sapp.eu/Download.html Did not do the RCs as limited disk space on CloudFoundry target. 2. i need to see what changes you want to make here: http://gparsdocs.d

Re: Release 2.4.6 and 2.5.0-beta?

2016-01-05 Thread jim northrop
Yes was just going to ask about that. Our website says GPars 1.3.0 is next as a SNAPSHOT pending a repository provider other than codehaus As i am working in that part of our documentation, it would be very easy to include stuff about 1.3.0-RC even if i just have placeholders in the material p

Re: Release 2.4.6 and 2.5.0-beta?

2016-01-05 Thread Russel Winder
Groovy currently ships with GPars 1.2.1, I wonder if we should contemplate switching to 1.3.0 (not as yet released) for the Groovy 2.5.0 release. Not the 2.4.6 release obviously since a change of dependency not driven by a bug fix is probably not a good thing. Obviously we have not released a GPar