Re: About the lazy consensus on Pull Requests

2019-01-26 Thread Paul King
Yes, it is always wise to notify the mailing list about upcoming major changes. While not every change will bring about discussion, in those cases where there is discussion, it can reduce the need to have to rework PRs. So it is often both courteous and efficient at the same time. On Sun, Jan 27,

Re: About the lazy consensus on Pull Requests

2019-01-26 Thread Remko Popma
No objection from me, assuming that major changes are brought up on the mailing list first. Remko > On Jan 27, 2019, at 3:09, Daniel.Sun wrote: > > Hi all, > > In order to make all major changes reviewed, I create PRs for each > major change. And the PRs will be merged in 72 hours by

About the lazy consensus on Pull Requests

2019-01-26 Thread Daniel.Sun
Hi all, In order to make all major changes reviewed, I create PRs for each major change. And the PRs will be merged in 72 hours by default if no one rejects the PRs. So I am not going to add any note like "merged in 72 hours if no one rejects" for each JIRA ticket and PR. If anyone