[RESULT][VOTE] Release Apache Groovy 2.4.17

2019-05-10 Thread Paul King
The vote has passed with 4 +1 binding votes and no other votes. I'll proceed with next steps. Cheers, Paul. On Mon, May 6, 2019 at 11:08 PM Paul King wrote: > > Dear development community, > > I am happy to start the VOTE thread for a Groovy 2.4.17 release! > > This release includes 4 bug fixes

Re: [VOTE] Release Apache Groovy 2.4.17

2019-05-07 Thread Jan Lukavský
Hi Paul, understood, thanks. Jan On 5/7/19 11:17 AM, Paul King wrote: PR884 made it into the 2.5 and 3 .0 beta releases but not the 2.4 release. The 2.4 branch is in low maintenance mode. I.e. only critical fixes or low risk cosmetic changes. We won't re-roll the 2.5/3 releases for PRs 923 &

Re: [VOTE] Release Apache Groovy 2.4.17

2019-05-07 Thread Paul King
PR884 made it into the 2.5 and 3 .0 beta releases but not the 2.4 release. The 2.4 branch is in low maintenance mode. I.e. only critical fixes or low risk cosmetic changes. We won't re-roll the 2.5/3 releases for PRs 923 & 924 but we'll take a look and merge when we get the chance if they make sens

Re: [VOTE] Release Apache Groovy 2.4.17

2019-05-07 Thread Jan Lukavský
Thanks Andres, sorry for that, Paul merged that (and probably rebased). I'm very, very sorry about my absolutely late activity, but I forgot one last thing that would make my life easier: https://issues.apache.org/jira/browse/GROOVY-9109 with PRs: https://github.com/apache/groovy/pull/924

Re: [VOTE] Release Apache Groovy 2.4.17

2019-05-06 Thread Andres Almiray
Jan, PR 884 targets master branch which stands for Groovy 3. This release is for Groovy 2.4.7 which means the PR needs to be rebased and target the GROOVY_2_4_X branch. Cheers, Andres --- Java Champion; Groovy Enthusiast JCP EC Associate Seat http://andres

Re: [VOTE] Release Apache Groovy 2.4.17

2019-05-06 Thread Jan Lukavský
Hi, I know that it might be already a little late, but (if I didn't miss anything) nobody commented on PR [1]. Any chance it could make it into the planned release? Thanks for comments, Jan [1] https://github.com/apache/groovy/pull/884 On 5/6/19 6:30 PM, Paul King wrote: We should see if w

Re: [VOTE] Release Apache Groovy 2.4.17

2019-05-06 Thread Daniel.Sun
As far as I remember, the locale issue has been fixed in master(See "-Duser.language=en") and run well on my local machine: https://github.com/apache/groovy/blob/master/gradle/test.gradle#L24 But the related fix is not merged into 2.4 branch. Here is the JIRA ticket: https://issues.apache.org/jir

Re: [VOTE] Release Apache Groovy 2.4.17

2019-05-06 Thread Paul King
We should see if we can make our tests Locale independent if we can for next time. Can you at least log it in Jira. Thanks. On Tue, May 7, 2019 at 2:19 AM Daniel.Sun wrote: > > +1 (binding) > > Here is the result of build scan: > https://gradle.com/s/j72ywyaymcvri > > There is a failed test bec

Re: [VOTE] Release Apache Groovy 2.4.17

2019-05-06 Thread Daniel.Sun
+1 (binding) Here is the result of build scan: https://gradle.com/s/j72ywyaymcvri There is a failed test because of locale, so I think it is still OK to release. Cheers, Daniel.Sun - Apache Groovy committer & PMC member Blog: http://blog.sunlan.me Twitter: @daniel_sun -- Sent from:

Re: [VOTE] Release Apache Groovy 2.4.17

2019-05-06 Thread Daniel Sun
On 2019/05/06 13:08:16, Paul King wrote: > Dear development community, > > I am happy to start the VOTE thread for a Groovy 2.4.17 release! > > This release includes 4 bug fixes/improvements as outlined in the changelog: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=1231

Re: [VOTE] Release Apache Groovy 2.4.17

2019-05-06 Thread Andres Almiray
+1 (binding) Building from source looks good -> https://gradle.com/s/opryaeza4evx2 Cheers, Andres --- Java Champion; Groovy Enthusiast JCP EC Associate Seat http://andresalmiray.com http://www.linkedin.com/in/aalmiray -- What goes up, must come down. Ask a

Re: [VOTE] Release Apache Groovy 2.4.17

2019-05-06 Thread Guillaume Laforge
+1 (binding) All tests ran fine on my machine, and my usual smoke tests in the Groovy console went fine as well. Guillaume On Mon, May 6, 2019 at 3:08 PM Paul King wrote: > > Dear development community, > > I am happy to start the VOTE thread for a Groovy 2.4.17 release! > > This release incl

Re: [VOTE] Release Apache Groovy 2.4.17

2019-05-06 Thread Andres Almiray
Hi Paul, The release notes is missing all the minor updates to AST transformations https://issues.apache.org/jira/browse/GROOVY-9050 https://issues.apache.org/jira/browse/GROOVY-9051 https://issues.apache.org/jira/browse/GROOVY-9052 https://issues.apache.org/jira/browse/GROOVY-9053 https://issues

[VOTE] Release Apache Groovy 2.4.17

2019-05-06 Thread Paul King
Dear development community, I am happy to start the VOTE thread for a Groovy 2.4.17 release! This release includes 4 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12345028 Tag: https://gitbox.apache.org/repo