Re: Remove Version from File Names in Distributions; Add Manifest

2015-07-28 Thread Jeff Adamson
either redundant or should be. --Jeff On Tue, Jul 28, 2015 at 5:04 PM, Henrik Martin wrote: > > On 7/28/15 8:55 AM, Jeff Adamson wrote: > > My non-contributor $0.02 would be exactly the opposite Henrik, for very > similar reasons. > > I would agree that the embeddable

Re: Remove Version from File Names in Distributions; Add Manifest

2015-07-28 Thread Jeff Adamson
My non-contributor $0.02 would be exactly the opposite Henrik, for very similar reasons. I would agree that the embeddable jar should include version number by default because that is supposed to be dropped around, but the rest of the lib is already version locked to a groovy version. If someone i

Re: GROOVY-7378

2015-05-11 Thread Jeff Adamson
pts, because it's easy to break things. We > don't have any integration test that would make sure we don't break > something, so we'll have to check what your PR implies in terms of > compatibility. > > 2015-05-11 15:33 GMT+02:00 Jeff Adamson : > >> I

GROOVY-7378

2015-05-11 Thread Jeff Adamson
I filed a bug along with a patch and github pull request a few weeks back. This was around the time of the migration to apache, but seems to have everything in the correct place. https://issues.apache.org/jira/browse/GROOVY-7378 https://github.com/apache/incubator-groovy/pull/5 I see other pull r