Re: RAT integration

2015-07-03 Thread Bertrand Delacretaz
On Thu, Jul 2, 2015 at 10:25 PM, Russel Winder wrote: > On Wed, 2015-07-01 at 07:19 +0200, Bertrand Delacretaz wrote: >> Yeah it's great, I've been using it ages ago to fake guitar solos on >> a >> syntheziser ;-) > Buy a guitar, put the RAT in the line, stop faking ;-) I already have way to many

Re: RAT integration

2015-07-02 Thread Russel Winder
On Wed, 2015-07-01 at 07:19 +0200, Bertrand Delacretaz wrote: > […] > Yeah it's great, I've been using it ages ago to fake guitar solos on > a > syntheziser ;-) Buy a guitar, put the RAT in the line, stop faking ;-) Sorry if I have turned this thread into a comedy line. I am working away from

Re: RAT integration

2015-06-30 Thread Bertrand Delacretaz
On Tue, Jun 30, 2015 at 10:01 PM, Russel Winder wrote: > ...And on a bizarre note: RAT is a distortion peddle for any instrument > with jack plug output. It has a trademark... Yeah it's great, I've been using it ages ago to fake guitar solos on a syntheziser ;-) Ours is "Apache Rat" (http://crea

Re: RAT integration

2015-06-30 Thread Russel Winder
And on a bizarre note: RAT is a distortion peddle for any instrument with jack plug output. It has a trademark. On Sun, 2015-06-28 at 14:03 +0200, Pascal Schumacher wrote: > Hello everybody, > > thanks to Paul the groovy build now uses the gradle RAT plugin. :) > > IMHO we should remove the comm

Re: RAT integration

2015-06-30 Thread Russel Winder
And there was me thinking rats were vermin. ;-) On Sun, 2015-06-28 at 14:03 +0200, Pascal Schumacher wrote: > Hello everybody, > > thanks to Paul the groovy build now uses the gradle RAT plugin. :) > > IMHO we should remove the commented out gradle licence plugin parts > from > the build scri

Re: RAT integration

2015-06-30 Thread Pascal Schumacher
ce plugin parts from the build scripts. What do you think? I think we can keep it. Rat will report errors, but the license plugin will let us update missing headers. It's no harm keeping it, at least temporarily. Especially the Rat integration is not as smooth as the license plugin (stil

Re: RAT integration

2015-06-30 Thread Pascal Schumacher
Paul realized this a few hours before: https://github.com/apache/incubator-groovy/commit/08386a0be236d395c264ada82a2e309315afa623 Thanks Paul! Am 29.06.2015 um 09:52 schrieb Bertrand Delacretaz: On Sun, Jun 28, 2015 at 2:03 PM, Pascal Schumacher wrote: ...IMHO we should fail the build on rat

Re: RAT integration

2015-06-30 Thread Pascal Schumacher
Hi Roman, Am 28.06.2015 um 21:19 schrieb Roman Shaposhnik: On Sun, Jun 28, 2015 at 5:03 AM, Pascal Schumacher wrote: Hello everybody, thanks to Paul the groovy build now uses the gradle RAT plugin. :) Another great bit of news! Thanks! :) Maybe it would be helpful to (also) run the RAT che

Re: RAT integration

2015-06-29 Thread Cédric Champeau
we can keep it. Rat will report errors, but the license plugin will let us update missing headers. It's no harm keeping it, at least temporarily. Especially the Rat integration is not as smooth as the license plugin (still based on CLI). > IMHO we should fail the build on rat errors. What do y

Re: RAT integration

2015-06-29 Thread Bertrand Delacretaz
On Sun, Jun 28, 2015 at 2:03 PM, Pascal Schumacher wrote: > ...IMHO we should fail the build on rat errors +1. it saves you from having to fix lots of things just before a release. -Bertrand

Re: RAT integration

2015-06-28 Thread Roman Shaposhnik
On Sun, Jun 28, 2015 at 5:03 AM, Pascal Schumacher wrote: > Hello everybody, > > thanks to Paul the groovy build now uses the gradle RAT plugin. :) Another great bit of news! > IMHO we should remove the commented out gradle licence plugin parts from the > build scripts. What do you think? > > IM

RAT integration

2015-06-28 Thread Pascal Schumacher
Hello everybody, thanks to Paul the groovy build now uses the gradle RAT plugin. :) IMHO we should remove the commented out gradle licence plugin parts from the build scripts. What do you think? IMHO we should fail the build on rat errors. What do you think? Maybe it would be helpful to (als