[GitHub] guacamole-client pull request #343: GUACAMOLE-526: Correct redirect issue wi...

2018-12-04 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-client/pull/343 GUACAMOLE-526: Correct redirect issue with CAS module These changes clean up code and correct a minor typo that caused the CAS redirect to fail. You can merge this pull request into a

[GitHub] guacamole-client pull request #342: GUACAMOLE-598: Ignore if current user ha...

2018-12-04 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/342#discussion_r238886562 --- Diff: guacamole/src/main/webapp/app/navigation/directives/guacUserMenu.js --- @@ -95,13 +95,10 @@ angular.module('navigation').directive('gu

[GitHub] guacamole-server pull request #205: GUACAMOLE-667: Enable loading configurat...

2018-12-04 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/205#discussion_r238850450 --- Diff: src/guacd/conf-file.c --- @@ -188,15 +188,21 @@ guacd_config* guacd_conf_load() { conf->key_file = NULL; #endif

[GitHub] guacamole-server pull request #205: GUACAMOLE-667: Enable loading configurat...

2018-12-04 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/205#discussion_r238848689 --- Diff: src/guacd/conf-args.c --- @@ -122,3 +128,15 @@ int guacd_conf_parse_args(guacd_config* config, int argc, char** argv) { }

[GitHub] guacamole-client pull request #342: GUACAMOLE-598: Ignore if current user ha...

2018-12-04 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/342 GUACAMOLE-598: Ignore if current user has no associated data. Authentication providers are not required to provide data for the users they authenticate. In this case, the data is neede

[GitHub] guacamole-server pull request #204: GUACAMOLE-354: Add Swiss-German keymap f...

2018-12-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/guacamole-server/pull/204 ---

[GitHub] guacamole-server pull request #207: GUACAMOLE-673: Create automatically need...

2018-12-04 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/207#discussion_r238667965 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c --- @@ -153,5 +153,42 @@ void guac_rdpdr_register_fs(guac_rdpdrPlugin* rdpdr, char* dr

[GitHub] guacamole-server pull request #207: GUACAMOLE-673: Create automatically need...

2018-12-04 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/207#discussion_r238668883 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c --- @@ -153,5 +153,42 @@ void guac_rdpdr_register_fs(guac_rdpdrPlugin* rdpdr, char* dr

[GitHub] guacamole-server pull request #207: GUACAMOLE-673: Create automatically need...

2018-12-04 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/207#discussion_r238670994 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c --- @@ -153,5 +153,42 @@ void guac_rdpdr_register_fs(guac_rdpdrPlugin* rdpdr, char* dr

[GitHub] guacamole-server pull request #207: GUACAMOLE-673: Create automatically need...

2018-12-04 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/207#discussion_r238669729 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c --- @@ -153,5 +153,42 @@ void guac_rdpdr_register_fs(guac_rdpdrPlugin* rdpdr, char* dr