[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #846: GUACAMOLE-1780: Fix TOTP interaction with SAML and SSL

2023-06-30 Thread via GitHub
jmuehlner commented on code in PR #846: URL: https://github.com/apache/guacamole-client/pull/846#discussion_r1248006675 ## extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/java/org/apache/guacamole/auth/sso/SSOAuthenticationEventListener.java: ## @@ -0,0 +1

[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #846: GUACAMOLE-1780: Fix TOTP interaction with SAML and SSL

2023-06-27 Thread via GitHub
jmuehlner commented on code in PR #846: URL: https://github.com/apache/guacamole-client/pull/846#discussion_r1244477360 ## extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/java/org/apache/guacamole/auth/sso/AuthenticationSessionManager.java: ## @@ -97,9 +14

[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #846: GUACAMOLE-1780: Fix TOTP interaction with SAML and SSL

2023-06-27 Thread via GitHub
jmuehlner commented on code in PR #846: URL: https://github.com/apache/guacamole-client/pull/846#discussion_r1244455421 ## extensions/guacamole-auth-sso/modules/guacamole-auth-sso-ssl/src/main/java/org/apache/guacamole/auth/ssl/AuthenticationEventListener.java: ## @@ -0,0 +1,74

[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #846: GUACAMOLE-1780: Fix TOTP interaction with SAML and SSL

2023-05-01 Thread via GitHub
jmuehlner commented on code in PR #846: URL: https://github.com/apache/guacamole-client/pull/846#discussion_r1181950825 ## extensions/guacamole-auth-sso/modules/guacamole-auth-sso-saml/src/main/java/org/apache/guacamole/auth/saml/AuthenticationEventListener.java: ## @@ -0,0 +1,7

[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #846: GUACAMOLE-1780: Fix TOTP interaction with SAML and SSL

2023-05-01 Thread via GitHub
jmuehlner commented on code in PR #846: URL: https://github.com/apache/guacamole-client/pull/846#discussion_r1181948531 ## guacamole-ext/src/main/java/org/apache/guacamole/net/auth/AuthenticationProvider.java: ## @@ -247,5 +247,42 @@ UserContext redecorate(UserContext decorated,