[GitHub] guacamole-client pull request #328: GUACAMOLE-232: Address regressions in ha...

2018-10-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/guacamole-client/pull/328 ---

[GitHub] guacamole-client pull request #328: GUACAMOLE-232: Address regressions in ha...

2018-10-03 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/328#discussion_r222398664 --- Diff: guacamole-common-js/src/main/webapp/modules/Keyboard.js --- @@ -953,37 +1006,58 @@ Guacamole.Keyboard = function Keyboard(element) {

[GitHub] guacamole-client pull request #328: GUACAMOLE-232: Address regressions in ha...

2018-10-03 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/328#discussion_r222318256 --- Diff: guacamole-common-js/src/main/webapp/modules/Keyboard.js --- @@ -953,37 +1006,58 @@ Guacamole.Keyboard = function Keyboard(element) {

[GitHub] guacamole-client pull request #328: GUACAMOLE-232: Address regressions in ha...

2018-10-02 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/328 GUACAMOLE-232: Address regressions in handling of keyboard modifiers. These changes address issues resulting from changes in [GUACAMOLE-232](https://issues.apache.org/jira/browse/GUACA