[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-15 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241958169 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -240,17 +244,24

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241933797 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java --- @@ -188,46 +183,50 @@ public

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241932591 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -240,17 +244,24

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241928473 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/conf/LdapDnGuacamoleProperty.java --- @@ -0,0 +1,50 @@

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241928458 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/conf/LdapFilterGuacamoleProperty.java --- @@ -0,0 +1,53 @

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241928420 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPConnectionService.java --- @@ -156,38 +146,84 @@ publ

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241928440 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java --- @@ -188,46 +183,50 @@ public

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241928405 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -240,17 +244,24

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241919019 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -240,17 +244,24

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241916742 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/conf/LdapDnGuacamoleProperty.java --- @@ -0,0 +1,50 @@

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241916700 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/conf/LdapFilterGuacamoleProperty.java --- @@ -0,0 +1,53 @

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241916665 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java --- @@ -188,46 +183,50 @@ public

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241916587 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java --- @@ -188,46 +183,50 @@ public

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241916521 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPConnectionService.java --- @@ -156,38 +146,84 @@ publ

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241916443 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -240,17 +244,24

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241916353 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -240,17 +244,24

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241905520 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -240,17 +244,2

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241910894 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/conf/LdapFilterGuacamoleProperty.java --- @@ -0,0 +1,53

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241911374 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/conf/LdapDnGuacamoleProperty.java --- @@ -0,0 +1,50 @@

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241906662 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPConnectionService.java --- @@ -156,38 +146,84 @@ pub

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241908453 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java --- @@ -188,46 +183,50 @@ public

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241902907 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java --- @@ -240,17 +244,2

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/345#discussion_r241907562 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java --- @@ -188,46 +183,50 @@ public

[GitHub] guacamole-client pull request #345: GUACAMOLE-234: Migrate to Apache Directo...

2018-12-09 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-client/pull/345 GUACAMOLE-234: Migrate to Apache Directory API for LDAP Extension This change request takes a new stab at migrating from the legacy Novell JLDAP API to the Apache Directory API for LDAP