[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-20 Thread sanhex
Github user sanhex commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r146083543 --- Diff: src/protocols/ssh/client.c --- @@ -70,8 +70,14 @@ int guac_ssh_client_free_handler(guac_client* client

[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-20 Thread sanhex
Github user sanhex commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r146078760 --- Diff: src/protocols/ssh/client.c --- @@ -70,8 +70,14 @@ int guac_ssh_client_free_handler(guac_client* client

[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-20 Thread sanhex
Github user sanhex commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r146027988 --- Diff: src/protocols/ssh/client.c --- @@ -70,8 +70,14 @@ int guac_ssh_client_free_handler(guac_client* client

[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-19 Thread sanhex
Github user sanhex commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r145845351 --- Diff: src/terminal/terminal.c --- @@ -413,8 +413,10 @@ guac_terminal* guac_terminal_create(guac_client* client, void

[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-19 Thread sanhex
Github user sanhex commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r145845105 --- Diff: src/protocols/ssh/client.c --- @@ -70,8 +70,14 @@ int guac_ssh_client_free_handler(guac_client* client

[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-19 Thread sanhex
Github user sanhex commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r145827462 --- Diff: src/terminal/terminal.c --- @@ -413,8 +413,10 @@ guac_terminal* guac_terminal_create(guac_client* client, void

[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-19 Thread sanhex
Github user sanhex commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r145826455 --- Diff: src/protocols/ssh/client.c --- @@ -70,8 +70,14 @@ int guac_ssh_client_free_handler(guac_client* client

[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-18 Thread sanhex
GitHub user sanhex opened a pull request: https://github.com/apache/incubator-guacamole-server/pull/118 GUACAMOLE-384: fixing segfault during ssh disconnect Root Cause: In guacd, when a SSH connection is terminated, guac_ssh_client_free_handler() will be called from

[GitHub] incubator-guacamole-server pull request #115: GUACAMOLE-400: Fix guacd crash...

2017-09-28 Thread sanhex
GitHub user sanhex opened a pull request: https://github.com/apache/incubator-guacamole-server/pull/115 GUACAMOLE-400: Fix guacd crash when ssh key fails Root Cause: In the ssh library of guacd, function ssh_client_thread(), when guac_ssh_get_user() fails to load private key

[GitHub] incubator-guacamole-server pull request #113: GUACAMOLE-396: Fixing ssh sock...

2017-09-25 Thread sanhex
GitHub user sanhex opened a pull request: https://github.com/apache/incubator-guacamole-server/pull/113 GUACAMOLE-396: Fixing ssh socket for IPv6 address GUACAMOLE-396: guacd cannot connect to ssh servers with IPv6 addresses Root Cause: In the ssh library of guacd, the