In message f944d83d0910072154n10694e10mc9c9cf80d35f5...@mail.gmail.com,
Alexey Varlamov writes:
I will do in few days.
Excellent. Thanks Alexey. If you plan to commit it yourself then be
aware of the ongoing website changes on the earlier [website] Moved
site to site/trunk thread but feel
In message a43fbc6a0909301705i465f46cbye3f889218dcfc...@mail.gmail.com,
Jesse Wilson writes:
So Regis and I disagree on the merit of maintaining indices. Actually
disagreeing on such things is generally healthy since mobile/Android
prefers simplicity and memory efficiency, whereas serverside
Part of the patch for HARMONY-6346 includes some improvements to the way
we handle localized exception messages. That prompted me to write down
a few thoughts...
I don't really like the way we do I18N of exception messages. We create
message string like this
throw new
Tim Ellison wrote:
Part of the patch for HARMONY-6346 includes some improvements to the way
we handle localized exception messages. That prompted me to write down
a few thoughts...
I don't really like the way we do I18N of exception messages. We create
message string like this
throw new
On 08/Oct/2009 14:21, Oliver Deakin wrote:
Tim Ellison wrote:
Part of the patch for HARMONY-6346 includes some improvements to the way
we handle localized exception messages. That prompted me to write down
a few thoughts...
I don't really like the way we do I18N of exception messages. We
Tim Ellison wrote:
On 08/Oct/2009 14:21, Oliver Deakin wrote:
Tim Ellison wrote:
Part of the patch for HARMONY-6346 includes some improvements to the way
we handle localized exception messages. That prompted me to write down
a few thoughts...
I don't really like the way we do I18N of
Mark,
Thanks for hanging along with me on these changes, and also for the heads up
on Regis' holiday.
On Thu, Oct 8, 2009 at 2:57 AM, Mark Hindess mark.hind...@googlemail.comwrote:
I think there is usually quite a lot of overlap between the goals of memory
efficiency and high throughput.
On Wed, Oct 7, 2009 at 1:26 PM, Tim Ellison t.p.elli...@gmail.com wrote:
I know that the InputStream here can only be a RAFStream or
InflaterInputStream, and both of them return available() as 1 so long as
the stream is not at the end, but in general I guess it is better to
read to the -1 eof
Mark and Tim,
Of the two giant patches I've submitted thus far
(archivehttps://issues.apache.org/jira/browse/HARMONY-6346and
crypto https://issues.apache.org/jira/browse/HARMONY-6347), you guys
omitted the MsgHelp changes. That's fine; those changes were
out-of-scope. But since I think the MsgHelp
I was wondering about our modules and potential for re-use.
For example, archive, auth, awt, imageio, nio, prefs, sql, security,
suncompat, swing, and x-net modules depend on non-API packages in luni.
This sucks from a re-use point of view since it means that you can't
re-use those modules
In message a43fbc6a0910081214x5eb9d71cnc2535457fa548...@mail.gmail.com,
Jesse Wilson writes:
Mark and Tim,
Of the two giant patches I've submitted thus far
(archivehttps://issues.apache.org/jira/browse/HARMONY-6346and
crypto https://issues.apache.org/jira/browse/HARMONY-6347), you guys
In message 4ace0d32.3060...@googlemail.com, Oliver Deakin writes:
Tim Ellison wrote:
On 08/Oct/2009 14:21, Oliver Deakin wrote:
Tim Ellison wrote:
Part of the patch for HARMONY-6346 includes some improvements to the way
we handle localized exception messages. That prompted
In message a43fbc6a0910080958t19bb1c40h94389bbf6d3ba...@mail.gmail.com,
Jesse Wilson writes:
Mark,
Thanks for hanging along with me on these changes, and also for the
heads up on Regis' holiday.
On Thu, Oct 8, 2009 at 2:57 AM, Mark Hindess mark.hind...@googlemail.com
wrote:
[ snipped:
In message 529434575.1255030111261.javamail.j...@brutus,
Jesse Wilson (JIRA) writes:
Remove @author tags from code
-
Key: HARMONY-6348
URL: https://issues.apache.org/jira/browse/HARMONY-6348
Project: Harmony
On Thu, Oct 8, 2009 at 4:23 PM, Mark Hindess mark.hind...@googlemail.comwrote:
If I was in your position I'd probably try to:
1) Revert the author removal or justify why I thought it made sense
to the upstream and do it in one big change. It looks like you
are doing this with
On Thu, Oct 8, 2009 at 2:23 PM, Mark Hindess mark.hind...@googlemail.comwrote:
I was wondering about our modules and potential for re-use.
For example, archive, auth, awt, imageio, nio, prefs, sql, security,
suncompat, swing, and x-net modules depend on non-API packages in luni.
This sucks
On Thu, Oct 8, 2009 at 9:31 AM, odea...@apache.org wrote:
Add null check to equals() method.
// Checks two CredOwner objects for equality.
@Override
public boolean equals(Object obj) {
+if (obj == null) {
+return false;
+}
It appears that Bloch suggests that we should have the following first:
if (!(object instanceof CredOwner)) return false;
Then, we can skip this check:
if (object instanceof CredOwner)
Regards,
Ramana
-Original Message-
From: Jesse Wilson [mailto:jessewil...@google.com]
18 matches
Mail list logo
