Re: [general] Remove @author tags from code (HARMONY-6348)

2009-10-13 Thread Xiao-Feng Li
On Tue, Oct 13, 2009 at 8:03 AM, sebb seb...@gmail.com wrote: On 12/10/2009, boot...@earthlink.net boot...@earthlink.net wrote:   [Original Message]   From: Tim Ellison t.p.elli...@gmail.com   To: dev@harmony.apache.org   Date: 10/9/2009 2:54:32 AM   Subject: Re: [general] Remove @author

Re: [jira] Commented: (HARMONY-6312) Concurrency problems in NIO

2009-10-13 Thread Regis
Jesse Wilson wrote: So Regis and I disagree on the merit of maintaining indices. Actually disagreeing on such things is generally healthy since mobile/Android prefers simplicity and memory efficiency, whereas serverside prefers high throughput. Yet I still feel that the index optimizations were

Re: [general] Remove @author tags from code (HARMONY-6348)

2009-10-13 Thread Tim Ellison
On 13/Oct/2009 01:03, sebb wrote: The problem with @author tags in code is that they can very quickly get out of date. After a few years of edits, how much of the original code is left? Have the tags been kept up to date? Does it really make sense to have recognition in the source code?

Re: svn commit: r824625 - in /harmony/enhanced/classlib/trunk/modules/nio/src: main/java/common/org/apache/harmony/nio/internal/SelectorImpl.java test/java/common/org/apache/harmony/nio/tests/java/nio

2009-10-13 Thread Regis
regi...@apache.org wrote: Author: regisxu Date: Tue Oct 13 07:35:56 2009 New Revision: 824625 URL: http://svn.apache.org/viewvc?rev=824625view=rev Log: return value of Selector.select() should be same with selectedKeys.size() Modified:

Re: [website] Moved site to site/trunk (and site/branches/live)

2009-10-13 Thread Mark Hindess
In message 200910061451.n96epjbk001...@d06av01.portsmouth.uk.ibm.com, Mark Hindess writes: I've moved the site repository to site/trunk and merged that to site/branches/live. You should use: svn switch https://svn.apache.org/repos/asf/harmony/standard/site/trunk to update a checkout

Re: svn commit: r824625 - in /harmony/enhanced/classlib/trunk/modules/nio/src: main/java/common/org/apache/harmony/nio/internal/SelectorImpl.java test/java/common/org/apache/harmony/nio/tests/java/nio

2009-10-13 Thread Regis
Regis wrote: regi...@apache.org wrote: This commit is incorrect and causes SelectorTest failed on Windows, I'll fix it soon. Fixed at r824652. I found SelectorTest is in exclude list of linux, but it passes on my linux machine. It excluded in HARMONY-4116, does anyone can reproduce this

Re: [general] Remove @author tags from code (HARMONY-6348)

2009-10-13 Thread Mark Hindess
In message 9623c9a50910122312y7de4b5d5j7568786e226b9...@mail.gmail.com, Xiao-Feng Li writes: On Tue, Oct 13, 2009 at 8:03 AM, sebb seb...@gmail.com wrote: [SNIP] The problem with @author tags in code is that they can very quickly get out of date. After a few years of edits, how much

Re: [general] Remove @author tags from code (HARMONY-6348)

2009-10-13 Thread Mark Hindess
In message 4ad432b3.2040...@gmail.com, Tim Ellison writes: On 13/Oct/2009 01:03, sebb wrote: The problem with @author tags in code is that they can very quickly get out of date. After a few years of edits, how much of the original code is left? Have the tags been kept up to date? Does

Re: svn commit: r824006 - in /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net: DatagramPacket.java DatagramSocket.java

2009-10-13 Thread Jesse Wilson
On Mon, Oct 12, 2009 at 7:18 PM, Nathan Beyer nbe...@gmail.com wrote: Honestly, the synchronization probably isn't appropriate on any of the accessor/mutators - the granularity isn't correct. The locking probably needs to encompass the entire method on DatagramSocket while working on a

Re: [general] Remove @author tags from code (HARMONY-6348)

2009-10-13 Thread Xiao-Feng Li
Mark, thanks for the explanations. I personally have no strong opinion on this. Since you are contributing on this, in Apache way, you probably make final call. :) Thanks, xiaofeng On Tue, Oct 13, 2009 at 8:56 PM, Mark Hindess mark.hind...@googlemail.com wrote: In message

Re: [general] Remove @author tags from code (HARMONY-6348)

2009-10-13 Thread Nathan Beyer
Should we just start a Contributors page on the wiki and be done with it? Deleting a name, check that it's on the wiki page. Committing a patch, check that the author is on the wiki page. -Nathan On Tue, Oct 13, 2009 at 1:12 AM, Xiao-Feng Li xiaofeng...@gmail.com wrote: On Tue, Oct 13, 2009 at