Jesse Wilson wrote:
On Fri, Oct 23, 2009 at 6:32 AM, odea...@apache.org wrote:
Author: odeakin
Date: Fri Oct 23 13:32:06 2009
New Revision: 829056
URL: http://svn.apache.org/viewvc?rev=829056view=rev
Log:
The port library hysock_connect_with_timeout() function only takes an
unsigned 32bit
On Mon, Oct 26, 2009 at 8:26 AM, Oliver Deakin oliver.dea...@googlemail.com
wrote:
Wouldn't it be more appropriate to just relax the constraints on
hysock_connect_with_timeout?
Sure, what would you suggest? I believe the reason the portlib function was
implemented this way (only a short
Harmony Team,
Some of the Java code in Harmony suffers from being written in a non-Java
style. In particular, our Java code often attempts to limit the number of
exit points from a method. This approach is common in C/C++ programs because
of the need to manually collect garbage. But the approach
Harmony Team,
Continuing along with a theme, there's another C/C++ism in our Java code
that frustrates me. Our Java code frequently inverts conditions from their
natural language form. From HttpURLConnectionImpl:
if (null == resHeader) {
resHeader = new Header();
On 27 October 2009 Jesse Wilson wrote:
Harmony Team,
Some of the Java code in Harmony suffers from being written in a non-Java
style. In particular, our Java code often attempts to limit the number of
exit points from a method. This approach is common in C/C++ programs
because of the need to
The construction which kills me is:
if some string.equals(str) instead of if str.equals(some string)
But unfortunately the first form is better then second one :)
Alexey
2009/10/27 Jesse Wilson jessewil...@google.com:
Harmony Team,
Continuing along with a theme, there's another C/C++ism in
2009/10/27 Gregory Shimansky gshiman...@apache.org:
On 27 October 2009 Jesse Wilson wrote:
Harmony Team,
Some of the Java code in Harmony suffers from being written in a non-Java
style. In particular, our Java code often attempts to limit the number of
exit points from a method. This
In message c3755b3a0910261503l3cb0118br548d49b61e9d6...@mail.gmail.com,
Alexey Petrenko writes:
2009/10/27 Gregory Shimansky gshiman...@apache.org:
On 27 October 2009 Jesse Wilson wrote:
Harmony Team,
Some of the Java code in Harmony suffers from being written in a
non-Java
In message a43fbc6a0910261457r73912ed5k70e90e558908b...@mail.gmail.com,
Jesse Wilson writes:
Harmony Team,
Continuing along with a theme, there's another C/C++ism in our Java
code that frustrates me. Our Java code frequently inverts conditions
from their natural language form. From
On Mon, Oct 26, 2009 at 3:44 PM, Mark Hindess
mark.hind...@googlemail.comwrote:
Modern programmers do refactoring and testing. I'm more than happy with
this. I want our code to be readable and using idiomatic style goes a
long way to achieving that. Working is important but being
On 26/10/2009, Alexey Petrenko alexey.a.petre...@gmail.com wrote:
The construction which kills me is:
if some string.equals(str) instead of if str.equals(some string)
But unfortunately the first form is better then second one :)
Surely it's only better if the str variable can be null?
On Sun, Oct 25, 2009 at 11:34 PM, Charles Ditzel cldte...@gmail.com wrote:
Thanks, Nathan. I still don't see a 64 bit Windows Harmony JVM
in the site Downloads section. [comments embedded]
On Oct 24, 2009, at 5:13 PM, Nathan Beyer wrote:
On Fri, Oct 23, 2009 at 12:30 PM, Charles Ditzel
On Mon, Oct 26, 2009 at 6:15 PM, Jesse Wilson jessewil...@google.com wrote:
On Mon, Oct 26, 2009 at 3:44 PM, Mark Hindess
mark.hind...@googlemail.comwrote:
Modern programmers do refactoring and testing. I'm more than happy with
this. I want our code to be readable and using idiomatic style
13 matches
Mail list logo
