Re: Problems bulding with VS 2008

2009-11-09 Thread Tim Ellison
On 09/Nov/2009 04:20, Charles Lee wrote: That's strange. I also encounter the same problem when I build federate. Ok, I'll go through and remove the /comment options from the link lines. In the meantime I've just removed the comment pass through in our rules at repo revision r834004. FWIW I'm

Re: [classlib] Fixing an unsafe reference in InputStream

2009-11-09 Thread Tim Ellison
On 05/Nov/2009 20:43, Alexei Fedotov wrote: I enjoyed the simple, but neat optimization. Let me question if the enlarged buffer should be stored at skipBuf. 1. Escaping reference always causes optimization problems. A reasonable JIT can drop a local array allocation if it is possible to

Re: [classlib][modularity] Logging performance improvements (HARMONY-6362)

2009-11-09 Thread Tim Ellison
On 27/Oct/2009 16:32, Jesse Wilson wrote: On Tue, Oct 27, 2009 at 7:20 AM, Tim Ellison t.p.elli...@gmail.com wrote: The improvement in performance is impressive. What is the contribution made by the use of the CopyOnWriteArrayList? CopyOnWriteArrayList is ideal for situations when the

Re: [announce] New committer - Jesse Wilson

2009-11-09 Thread Oliver Deakin
Congratulations! Tim Ellison wrote: On behalf of the PMC, I am delighted to welcome Jesse Wilson as our newest committer on the Apache Harmony project. Jesse has been sending in numerous patches to core areas of the codebase for quite a while, and has been participating in the discussions on

Re: [classlib] Fixing an unsafe reference in InputStream

2009-11-09 Thread Vijay Menon
Perhaps a dumb question - but is there a really a performance issue with always using a stack-local localBuf and removing the shared static? The code is simpler, and memory allocation is usually a fast operation. The code below does look semantically safe, but there is a potential performance

Re: [announce] New committer - Jesse Wilson

2009-11-09 Thread Alexei Fedotov
Congratulations! On Mon, Nov 9, 2009 at 5:03 PM, Oliver Deakin oliver.dea...@googlemail.comwrote: Congratulations! Tim Ellison wrote: On behalf of the PMC, I am delighted to welcome Jesse Wilson as our newest committer on the Apache Harmony project. Jesse has been sending in numerous

Re: Anyone work on the MIPS machines?

2009-11-09 Thread Christopher Sabol
Hi all, I work with Charles. Currently I'm working on a JET port to MIPS. Since I haven't done any work on DRLVM, it's a learning experience. I've taken the approach of stubbing out the port layer routines for MIPS with aborts and working through components on an as needed basis. That helps

build a java-6 version of harmony

2009-11-09 Thread Vijay Menon
Hi, Are there instructions on how to build a Java 6 version of Harmony? E.g., I see binary snapshots for both 5 and 6 at: http://harmony.apache.org/download.cgi, but the build instructions at http://harmony.apache.org/quickhelp_contributors.html#3. Starting the Federated Build appear to be for

Re: [classlib][modularity] Logging performance improvements (HARMONY-6362)

2009-11-09 Thread Jesse Wilson
On Mon, Nov 9, 2009 at 4:14 AM, Tim Ellison t.p.elli...@gmail.com wrote: I didn't mean to ask Why is a CopyOnWriteArrayList useful?, rather what did it contribute to your logging improvements, e.g. correctness that would require tons of duplicate coding otherwise, or performance numbers, etc.

Re: Problems bulding with VS 2008

2009-11-09 Thread Charles Lee
About comment option, I have no idea now :-( On Mon, Nov 9, 2009 at 5:31 PM, Tim Ellison t.p.elli...@gmail.com wrote: On 09/Nov/2009 04:20, Charles Lee wrote: That's strange. I also encounter the same problem when I build federate. Ok, I'll go through and remove the /comment options from

Re: build a java-6 version of harmony

2009-11-09 Thread Charles Lee
Hello, You can checkout the java6 code from the branch java6. IIRC, the build instruction is the same as java5 On Tue, Nov 10, 2009 at 5:25 AM, Vijay Menon v...@google.com wrote: Hi, Are there instructions on how to build a Java 6 version of Harmony? E.g., I see binary snapshots for both

Re: build a java-6 version of harmony

2009-11-09 Thread Vijay Menon
Thanks! On Mon, Nov 9, 2009 at 7:20 PM, Charles Lee littlee1...@gmail.com wrote: Hello, You can checkout the java6 code from the branch java6. IIRC, the build instruction is the same as java5 On Tue, Nov 10, 2009 at 5:25 AM, Vijay Menon v...@google.com wrote: Hi, Are there

Re: [classlib][modularity] Logging performance improvements (HARMONY-6362)

2009-11-09 Thread Nathan Beyer
On Mon, Nov 9, 2009 at 4:31 PM, Jesse Wilson jessewil...@google.com wrote: On Mon, Nov 9, 2009 at 4:14 AM, Tim Ellison t.p.elli...@gmail.com wrote: I didn't mean to ask Why is a CopyOnWriteArrayList useful?, rather what did it contribute to your logging improvements, e.g. correctness that

Re: svn commit: r834316 - /harmony/enhanced/classlib/trunk/support/src/test/java/tests/support/Streams.java

2009-11-09 Thread Nathan Beyer
Jesse, Make sure to setup your SVN config to enable auto-props such that new files have 'svn:eol-style=native'. Thanks On Mon, Nov 9, 2009 at 9:06 PM, jessewil...@apache.org wrote: Author: jessewilson Date: Tue Nov 10 03:06:30 2009 New Revision: 834316 URL:

Re: [classlib] BufferedReader and FileInputStream.available()

2009-11-09 Thread Regis
enh wrote: On Fri, Nov 6, 2009 at 02:28, Mark Hindess mark.hind...@googlemail.com wrote: In message 4af3f7de.3020...@gmail.com, Tim Ellison writes: On 06/Nov/2009 03:06, Regis wrote: Mark Hindess wrote: In message 96933a4d0911051045p61431af5ie2cecb850a622...@mail.gmail.com, enh writes: On

Re: Anyone work on the MIPS machines?

2009-11-09 Thread Charles Hardin
Chris basically stated where we are... I am going to try and just send a big diff pretty soon, so you can see it - but, part of the delivery is breaking down the patches into consumable pieces on the mailing list... Unfortunately, we have been doing this for an RD project and this is not our

Re: [classlib] BufferedReader and FileInputStream.available()

2009-11-09 Thread Ray Chen
Hi Regis, Maybe add the z/OS newline, on z/OS 0x15 means the newline. You can refer to PrintStream.write(int) for this. On Tue, Nov 10, 2009 at 12:35 PM, Regis xu.re...@gmail.com wrote: enh wrote: On Fri, Nov 6, 2009 at 02:28, Mark Hindess mark.hind...@googlemail.com wrote: In message

Re: [classlib] BufferedReader and FileInputStream.available()

2009-11-09 Thread Regis
Ray Chen wrote: Hi Regis, Maybe add the z/OS newline, on z/OS 0x15 means the newline. You can refer to PrintStream.write(int) for this. how about this: if ((out.position() offset) (out.get(out.position() - 1) == '\n' || out .get(out.position() - 1) == 0x15)) {

Re: [classlib] BufferedReader and FileInputStream.available()

2009-11-09 Thread Ray Chen
Shall we store the return value of out.position()-1 to avoid invoking it twice? If it is too tiny for performace improvement, current patch seems good for me. On Tue, Nov 10, 2009 at 2:04 PM, Regis xu.re...@gmail.com wrote: Ray Chen wrote: Hi Regis, Maybe add the z/OS newline, on z/OS 0x15

Re: [classlib] BufferedReader and FileInputStream.available()

2009-11-09 Thread enh
Is noone concerned about pooping this ebcdic cruft all over the place? Shouldn't it be factored out into an isNewline method somewhere? On Nov 9, 2009 10:10 PM, Ray Chen clrayc...@gmail.com wrote: Shall we store the return value of out.position()-1 to avoid invoking it twice? If it is too tiny

Re: Anyone work on the MIPS machines?

2009-11-09 Thread Tianwei
Hi, Charles, Chris, Thanks very much for sharing the information. Then I will wait for your patches ;-). Thanks. Tianwei On Tue, Nov 10, 2009 at 1:02 PM, Charles Hardin ckhar...@gmail.com wrote: Chris basically stated where we are... I am going to try and just send a big diff pretty