On 30/Nov/2009 06:31, enh wrote:
On Sun, Nov 29, 2009 at 22:27, Jesse Wilson jessewil...@google.com wrote:
On Thu, Nov 26, 2009 at 10:44 AM, Tim Ellison t.p.elli...@gmail.com wrote:
I know the arguments that say available() should not be used to judge
the total number of bytes that can be
On Mon, Nov 30, 2009 at 2:08 AM, Tim Ellison t.p.elli...@gmail.com wrote:
The method JarFile#getInputStream(ZipEntry) is spec'd to return an
InputStream, not a ZipInputStream.
Furthermore, as I showed, the RI returns a stream that answers with
available() 1, i.e. it follows the InputStream
On Thu, Nov 26, 2009 at 10:44 AM, Tim Ellison t.p.elli...@gmail.com wrote:
I know the arguments that say available() should not be used to judge
the total number of bytes that can be read, but it seems that a number
of applications (including our generated parser?) use it in this way.
And if
On Sun, Nov 29, 2009 at 22:27, Jesse Wilson jessewil...@google.com wrote:
On Thu, Nov 26, 2009 at 10:44 AM, Tim Ellison t.p.elli...@gmail.com wrote:
I know the arguments that say available() should not be used to judge
the total number of bytes that can be read, but it seems that a number
of
enh wrote:
may as well fix the lot, rather than sniff these out one by one...
Agreed, although we cannot fix them now for M12. Could you log these in
a JIRA so we have a record of them please?
Regards,
Oliver
./rmi/src/main/java/java/rmi/server/RMIClassLoader.java:214:
byte[] buf = new
Tim Ellison wrote:
On 26/Nov/2009 18:44, Tim Ellison wrote:
On 26/Nov/2009 17:00, Oliver Deakin wrote:
snip
I'll bet you a beer that it is our friend available() again...
Consider this:
static final String NAME = javax/swing/text/html/parser/html32.bdtd;
public void test()
Tim Ellison wrote:
snip
FYI here is my hacked available() impl, which needs some testing before
it is good to go in..
With this patch for available() applied the ASN1Exception no longer gets
thrown in BerInputStream.read(), but instead an ASN1Exception is thrown
in
On Fri, Nov 27, 2009 at 5:30 AM, Oliver Deakin
oliver.dea...@googlemail.com wrote:
Tim Ellison wrote:
snip
FYI here is my hacked available() impl, which needs some testing before
it is good to go in..
With this patch for available() applied the ASN1Exception no longer gets
thrown in
Correct.
On Nov 27, 2009 1:10 PM, Nathan Beyer ndbe...@apache.org wrote:
On Fri, Nov 27, 2009 at 5:30 AM, Oliver Deakin oliver.dea...@googlemail.com
wrote:Tim Ellis...
Isn't this still incorrect? The available() method isn't equivalent to
what's left in the stream - it's just what's
I have updated this morning and I only see 1 consistent failure on
Windows x86 now:
Name Tests
Errors Failures
javax.swing.text.html.HTMLDocument_Reader_ActionsTest
58 1 1
The bad news is that running this
In message 4b0e6f23.8070...@googlemail.com, Oliver Deakin writes:
I have updated this morning and I only see 1 consistent failure on
Windows x86 now:
Name Tests
Errors Failures
In message 200911261245.naqcjwbj010...@d06av01.portsmouth.uk.ibm.com, Mark
Hindess writes:
In message 4b0e6f23.8070...@googlemail.com, Oliver Deakin writes:
I have updated this morning and I only see 1 consistent failure on
Windows x86 now:
Name
On 26/Nov/2009 13:14, Mark Hindess wrote:
In message 200911261245.naqcjwbj010...@d06av01.portsmouth.uk.ibm.com, Mark
Hindess writes:
In message 4b0e6f23.8070...@googlemail.com, Oliver Deakin writes:
I have updated this morning and I only see 1 consistent failure on
Windows x86 now:
Name
I've found that if I prepend the classpath with the M11 versions of
ZipEntry and ZipFile and run using the M11 hyarchive.dll both the
failing swing tests pass. If I run the post-r822846 version of those
classes, still on the M11 natives, then the tests fail again which seems
to indicate that
In message 4b0e8e27.50...@gmail.com, Tim Ellison writes:
On 26/Nov/2009 13:14, Mark Hindess wrote:
In message 200911261245.naqcjwbj010...@d06av01.portsmouth.uk.ibm.com,
Mark Hindess writes:
In message 4b0e6f23.8070...@googlemail.com, Oliver Deakin writes:
I have updated this morning and
In message 200911261508.naqf8zsu002...@d06av02.portsmouth.uk.ibm.com,
Mark Hindess writes:
While trying to find a smaller reproducer I noticed that:
new HTMLEditorKit().read(new StringReader(
htmlbodypre/pre/body/html), doc, 0);
Oops. I missed that you still need:
A little more progress.
It looks like we're reading javax\swing\text\html\parser\html32.bdtd
(which is where the ZipFile/ZipEntry classes come in). I see that with
the M12 version of those classes we end up throwing an ASN1Exception at
line 886 of BerInputStream.java (right at the start of
On 26/Nov/2009 18:44, Tim Ellison wrote:
On 26/Nov/2009 17:00, Oliver Deakin wrote:
A little more progress.
It looks like we're reading javax\swing\text\html\parser\html32.bdtd
(which is where the ZipFile/ZipEntry classes come in). I see that with
the M12 version of those classes we end up
may as well fix the lot, rather than sniff these out one by one...
./rmi/src/main/java/java/rmi/server/RMIClassLoader.java:214:
byte[] buf = new byte[in.available()];
./luni/src/main/java/org/apache/harmony/luni/util/InputStreamExposer.java:86:
buffer = new byte[available];
Could somebody please review the patch on HARMONY-6386 and approve it's
application for M12?
After the milestone I'll refactor the code to move this utility method
into LUNI. For now this is minimal disruption.
Regards,
Tim
On 25/Nov/2009 02:53, Regis wrote:
Jesse Wilson wrote:
On Tue, Nov
In message 4b0cf157.5030...@gmail.com, Tim Ellison writes:
Could somebody please review the patch on HARMONY-6386 and approve it's
application for M12?
+1. This fixes the sound test failures I was seeing.
-Mark.
On 24/Nov/2009 14:31, Tim Ellison wrote:
Name Tests Errors Failures
org.apache.harmony.tests.tools.javac 2 1 0
This is a failure caused by missing JAR files on the test classpath.
We used to have explicit code to find
In message 4b0d33e3.5090...@gmail.com, Tim Ellison writes:
On 24/Nov/2009 14:31, Tim Ellison wrote:
Name Tests Errors Failures
org.apache.harmony.tests.tools.javac 2 1 0
This is a failure caused by missing JAR
On 24/Nov/2009 17:12, Tim Ellison wrote:
On 24/Nov/2009 16:11, Jesse Wilson wrote:
On Tue, Nov 24, 2009 at 6:31 AM, Tim Ellison t.p.elli...@gmail.com wrote:
Name Tests Errors Failures
org.apache.harmony.logging.tests.java.util.logging13 1
I currently see the following 5 failures and 10 errors when testing r883666
Name Tests Errors Failures
javax.swing 17 0 1
javax.swing.plaf.basic18 0 1
I see 6 failures and 7 errors running on Windows x86 at r883734
Name Tests Errors
Failures
java.awt.WindowTest7 0
1
javax.swing.ImageIcon_MultithreadedTest
On Tue, Nov 24, 2009 at 6:31 AM, Tim Ellison t.p.elli...@gmail.com wrote:
Name Tests Errors Failures
org.apache.harmony.logging.tests.java.util.logging13 1 0
This particular failure isn't being reported by Hudson...
On Tue, Nov 24, 2009 at 9:12 AM, Tim Ellison t.p.elli...@gmail.com wrote:
Seems to be caused by a change in the implementation of available() for
InputStreams on Zip entries.
The failing code is in
org.apache.harmony.sound.utils.ProviderService#getProviders(String) when
it tries to read the
On Tue, Nov 24, 2009 at 11:43 AM, Jesse Wilson jessewil...@google.com wrote:
On Tue, Nov 24, 2009 at 9:12 AM, Tim Ellison t.p.elli...@gmail.com wrote:
Seems to be caused by a change in the implementation of available() for
InputStreams on Zip entries.
The failing code is in
Jesse Wilson wrote:
On Tue, Nov 24, 2009 at 9:12 AM, Tim Ellison t.p.elli...@gmail.com wrote:
Seems to be caused by a change in the implementation of available() for
InputStreams on Zip entries.
The failing code is in
org.apache.harmony.sound.utils.ProviderService#getProviders(String) when
it
30 matches
Mail list logo
