Re: Idiomatic Java: return-at-method-end in Harmony

2009-10-28 Thread Mark Hindess
In message c3755b3a0910270918i17a3fb1ft21552999e112b...@mail.gmail.com, Alexey Petrenko writes: I agree that the code readability is good. No doubt here. Unfortunately, rewriting the code which works fine but does not follow some our internal vision can easily offend the original authors

Re: Idiomatic Java: return-at-method-end in Harmony

2009-10-27 Thread Alexei Fedotov
I like literate threads from Jesse just because they recall understanding and participation feelings. :-) On Tue, Oct 27, 2009 at 12:06 PM, Tim Ellison t.p.elli...@gmail.com wrote: As I general rule (which is, of course, made to be broken as you sit in front of the editor where it suddenly

Idiomatic Java: return-at-method-end in Harmony

2009-10-26 Thread Jesse Wilson
Harmony Team, Some of the Java code in Harmony suffers from being written in a non-Java style. In particular, our Java code often attempts to limit the number of exit points from a method. This approach is common in C/C++ programs because of the need to manually collect garbage. But the approach

Re: Idiomatic Java: return-at-method-end in Harmony

2009-10-26 Thread Gregory Shimansky
On 27 October 2009 Jesse Wilson wrote: Harmony Team, Some of the Java code in Harmony suffers from being written in a non-Java style. In particular, our Java code often attempts to limit the number of exit points from a method. This approach is common in C/C++ programs because of the need to

Re: Idiomatic Java: return-at-method-end in Harmony

2009-10-26 Thread Alexey Petrenko
2009/10/27 Gregory Shimansky gshiman...@apache.org: On 27 October 2009 Jesse Wilson wrote: Harmony Team, Some of the Java code in Harmony suffers from being written in a non-Java style. In particular, our Java code often attempts to limit the number of exit points from a method. This

Re: Idiomatic Java: return-at-method-end in Harmony

2009-10-26 Thread Mark Hindess
In message c3755b3a0910261503l3cb0118br548d49b61e9d6...@mail.gmail.com, Alexey Petrenko writes: 2009/10/27 Gregory Shimansky gshiman...@apache.org: On 27 October 2009 Jesse Wilson wrote: Harmony Team, Some of the Java code in Harmony suffers from being written in a non-Java

Re: Idiomatic Java: return-at-method-end in Harmony

2009-10-26 Thread Jesse Wilson
On Mon, Oct 26, 2009 at 3:44 PM, Mark Hindess mark.hind...@googlemail.comwrote: Modern programmers do refactoring and testing. I'm more than happy with this. I want our code to be readable and using idiomatic style goes a long way to achieving that. Working is important but being

Re: Idiomatic Java: return-at-method-end in Harmony

2009-10-26 Thread Nathan Beyer
On Mon, Oct 26, 2009 at 6:15 PM, Jesse Wilson jessewil...@google.com wrote: On Mon, Oct 26, 2009 at 3:44 PM, Mark Hindess mark.hind...@googlemail.comwrote: Modern programmers do refactoring and testing.  I'm more than happy with this.  I want our code to be readable and using idiomatic style