Re: svn commit: r823222 - /harmony/enhanced/classlib/trunk/modules/auth/src/main/java/common/javax/security/auth/PrivateCredentialPermission.java

2009-10-16 Thread Oliver Deakin
Tim Ellison wrote: On 09/Oct/2009 04:29, Jesse Wilson wrote: On Thu, Oct 8, 2009 at 9:31 AM, odea...@apache.org wrote: Add null check to equals() method. // Checks two CredOwner objects for equality. @Override public boolean equals(Object obj) {

Re: svn commit: r823222 - /harmony/enhanced/classlib/trunk/modules/auth/src/main/java/common/javax/security/auth/PrivateCredentialPermission.java

2009-10-09 Thread Tim Ellison
On 09/Oct/2009 04:29, Jesse Wilson wrote: On Thu, Oct 8, 2009 at 9:31 AM, odea...@apache.org wrote: Add null check to equals() method. // Checks two CredOwner objects for equality. @Override public boolean equals(Object obj) { +if (obj == null) {

Re: svn commit: r823222 - /harmony/enhanced/classlib/trunk/modules/auth/src/main/java/common/javax/security/auth/PrivateCredentialPermission.java

2009-10-09 Thread Tim Ellison
On 09/Oct/2009 06:28, Ramana Polavarapu wrote: It appears that Bloch suggests that we should have the following first: if (!(object instanceof CredOwner)) return false; Then, we can skip this check: if (object instanceof CredOwner) That is pretty much what Jesse wrote. Ok you

Re: svn commit: r823222 - /harmony/enhanced/classlib/trunk/modules/auth/src/main/java/common/javax/security/auth/PrivateCredentialPermission.java

2009-10-08 Thread Jesse Wilson
On Thu, Oct 8, 2009 at 9:31 AM, odea...@apache.org wrote: Add null check to equals() method. // Checks two CredOwner objects for equality. @Override public boolean equals(Object obj) { +if (obj == null) { +return false; +}

RE: svn commit: r823222 - /harmony/enhanced/classlib/trunk/modules/auth/src/main/java/common/javax/security/auth/PrivateCredentialPermission.java

2009-10-08 Thread Ramana Polavarapu
It appears that Bloch suggests that we should have the following first: if (!(object instanceof CredOwner)) return false; Then, we can skip this check: if (object instanceof CredOwner) Regards, Ramana -Original Message- From: Jesse Wilson [mailto:jessewil...@google.com]