Re: svn commit: r883478 - in /harmony/enhanced/classlib/trunk: modules/archive/make/exclude.common modules/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/JarFileTest.java suppo

2009-11-23 Thread Jesse Wilson
My bad for committing during the code freeze. Does it make sense to limit test changes during the code freeze? I don't see any benefit.

Re: svn commit: r883478 - in /harmony/enhanced/classlib/trunk: modules/archive/make/exclude.common modules/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/JarFileTest.java suppo

2009-11-23 Thread Tim Ellison
On 23/Nov/2009 20:27, Jesse Wilson wrote: My bad for committing during the code freeze. So you're going to rollback, esp. so we don't exclude all the other tests in that type? Does it make sense to limit test changes during the code freeze? I don't see any benefit. We ensure that the tests

Re: svn commit: r883478 - in /harmony/enhanced/classlib/trunk: modules/archive/make/exclude.common modules/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/JarFileTest.java suppo

2009-11-23 Thread Jesse Wilson
On Mon, Nov 23, 2009 at 2:29 PM, Tim Ellison t.p.elli...@gmail.com wrote: On 23/Nov/2009 20:27, Jesse Wilson wrote: My bad for committing during the code freeze. So you're going to rollback, esp. so we don't exclude all the other tests in that type? I can certainly rollback the changes to

Re: svn commit: r883478 - in /harmony/enhanced/classlib/trunk: modules/archive/make/exclude.common modules/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/JarFileTest.java suppo

2009-11-23 Thread sebb
On 23/11/2009, Jesse Wilson jessewil...@google.com wrote: On Mon, Nov 23, 2009 at 2:29 PM, Tim Ellison t.p.elli...@gmail.com wrote: On 23/Nov/2009 20:27, Jesse Wilson wrote: My bad for committing during the code freeze. So you're going to rollback, esp. so we don't exclude all the

Re: svn commit: r883478 - in /harmony/enhanced/classlib/trunk: modules/archive/make/exclude.common modules/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/JarFileTest.java suppo

2009-11-23 Thread Nathan Beyer
On Mon, Nov 23, 2009 at 5:08 PM, sebb seb...@gmail.com wrote: On 23/11/2009, Jesse Wilson jessewil...@google.com wrote: On Mon, Nov 23, 2009 at 2:29 PM, Tim Ellison t.p.elli...@gmail.com wrote:   On 23/Nov/2009 20:27, Jesse Wilson wrote:   My bad for committing during the code freeze.    

Re: svn commit: r883478 - in /harmony/enhanced/classlib/trunk: modules/archive/make/exclude.common modules/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/JarFileTest.java suppo

2009-11-23 Thread Jesse Wilson
On Mon, Nov 23, 2009 at 6:01 PM, Nathan Beyer ndbe...@apache.org wrote: I'd love to see the exclude files dropped in favor of JUnit @Ignore + reporting for those ignored tests. That would be extremely helpful in pointing out all of the excluded tests. Yes!

Re: svn commit: r883478 - in /harmony/enhanced/classlib/trunk: modules/archive/make/exclude.common modules/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/JarFileTest.java suppo

2009-11-23 Thread Nathan Beyer
On Mon, Nov 23, 2009 at 4:40 PM, Jesse Wilson jessewil...@google.com wrote: On Mon, Nov 23, 2009 at 2:29 PM, Tim Ellison t.p.elli...@gmail.com wrote: On 23/Nov/2009 20:27, Jesse Wilson wrote: My bad for committing during the code freeze. So you're going to rollback, esp. so we don't exclude

Re: svn commit: r883478 - in /harmony/enhanced/classlib/trunk: modules/archive/make/exclude.common modules/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/JarFileTest.java suppo

2009-11-23 Thread Ray Chen
Sounds good for use branching and freeze that code. -- Regards, Ray Chen

Re: svn commit: r883478 - in /harmony/enhanced/classlib/trunk: modules/archive/make/exclude.common modules/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/JarFileTest.java suppo

2009-11-23 Thread Regis
sebb wrote: On 23/11/2009, Jesse Wilson jessewil...@google.com wrote: On the other hand, if there are lots of failing tests, it can be difficult to spot tests that fail occasionally. Test cases that are known to fail could document this, e.g. by printing a message to say that the failure is