Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/688
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/686
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/680
Close this pull request. Move the code review to
https://github.com/apache/incubator-hawq/pull/686 due to manual merge of latest
test framework refactor.
---
If your project is set up for it
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/680
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/686
HAWQ-766. Add feature test for partition using new feature test framework
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huor/incubator
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/683
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/680
HAWQ-766. Add feature test for partition using new feature test framework
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huor/incubator
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/672#issuecomment-221454446
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/672#discussion_r64318728
--- Diff: configure ---
@@ -1545,7 +1543,8 @@ Optional Packages:
--with-perl build Perl modules (PL/Perl)
--with-python
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/668#issuecomment-220559489
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/662#issuecomment-220213835
+1 Overall it is good, except that a more meaningful name instead of
execute1 would be better
---
If your project is set up for it, you can reply to this email
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/660#discussion_r63537934
--- Diff: src/test/feature/query/test-prepare.cpp ---
@@ -0,0 +1,75 @@
+#include
+#include
+#include
+#include
+#include
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/660#discussion_r63537681
--- Diff: src/test/feature/query/test-prepare.cpp ---
@@ -0,0 +1,75 @@
+#include
+#include
+#include
+#include
+#include
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/660#discussion_r63537314
--- Diff: src/test/feature/query/ans/prepare-parameters.ans ---
@@ -0,0 +1,85 @@
+PREPARE q2(text) ASSELECT datname, datistemplate
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/659
HAWQ-738. Allocate query resource twice in function call through jdbc
Root cause analysis:
1. It uses exec_parse_message and exec_bind_message and allocate query
resource twice in
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/656#discussion_r63312102
--- Diff: src/test/feature/Makefile ---
@@ -1,32 +1,28 @@
top_builddir = ../../..
include $(top_builddir)/src/Makefile.global
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/647#issuecomment-219334129
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/643#issuecomment-218338690
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/636
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/629#issuecomment-217824493
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/636#discussion_r62446449
--- Diff: src/bin/gpfdist/Makefile ---
@@ -22,7 +22,8 @@ include $(top_builddir)/src/Makefile.global
LIBS := -levent -lyaml -lz -lbz2 -lssl
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/638#issuecomment-217765182
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/638#issuecomment-217631351
It would be good to support "make unittest" for hawq and its dependencies
as we have "make unittest" for libyarn, libhdfs3, pxf and "
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/636#issuecomment-217060325
@paul-guo-, please find my comments below:
1. it now uses lcov, gcov, genhtml directory instead of using the absolute
path, assuming they are system search path
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/636
HAWQ-716. Support code coverage build and report in hawq Makefile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huor/incubator-hawq
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/634
HAWQ-712. Add GUC gp_vmem_idle_resource_timeout back to do timeout for gang
release in idle session
You can merge this pull request into a Git repository by running:
$ git pull https
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/632#issuecomment-215036735
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/626#issuecomment-212279780
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/624#issuecomment-212211068
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/617#issuecomment-210304330
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/616#issuecomment-210272497
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/612#issuecomment-210246819
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/600
HAWQ-666. Restore to correct memory context after free query resource in
ExecutorEnd
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huor
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/593#issuecomment-208263544
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/592#issuecomment-208232381
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/584#issuecomment-207952371
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/581#issuecomment-207932336
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/565#issuecomment-207183443
@jiny2:
1. For critical parameters that might make RM unable to start if incorrect
value is specified, we need to error out while loading them. This makes user
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/566#issuecomment-207167202
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/539#issuecomment-204204473
+1. It is better to refine the message as below
{code}
snprintf(errorbuf, sizeof(errorbuf),
"%d of
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/541#issuecomment-203854432
+1 It is better to use SavedXXX instead of SaveXXX
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/540
HAWQ-611. Improve performance for query with entry database involved
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huor/incubator-hawq
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/530#issuecomment-203225800
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/517#issuecomment-202197847
It would be better to utilize xml related utilities instead of re-implement
it here again, i.e., append and update property in xml files. +1
---
If your project
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/504
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/505#issuecomment-201109073
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/495#issuecomment-201108040
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/504
HAWQ-588. Improve performance for truncate with small table
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huor/incubator-hawq huor_ml
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/496#issuecomment-200693236
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/454#issuecomment-200629188
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/492#issuecomment-200143626
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/485#issuecomment-199713761
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/480#issuecomment-199599974
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/461#issuecomment-198154113
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/452#issuecomment-196675702
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/430#issuecomment-196187516
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/434#issuecomment-195159931
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/431#issuecomment-194778876
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/429#issuecomment-194721617
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/424#issuecomment-194669546
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/414#issuecomment-193065906
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/409
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/410#issuecomment-192052040
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/409
HAWQ-488. Fix bug which cannot drop schema madlib and re-deploy MADlib in
schema madlib
The fix are in two folds:
1. Cannot drop schema madlib and re-deploy MADlib in schema madlib
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/406#discussion_r54839613
--- Diff: src/backend/tcop/postgres.c ---
@@ -4880,7 +4881,18 @@ PostgresMain(int argc, char *argv[], const char
*username
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/395#issuecomment-190009483
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/388
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/393
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/393
HAWQ-198. Build-in functions will be executed in resource_negotiator stage
which causes it will be executed twice
You can merge this pull request into a Git repository by running:
$ git
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/392#issuecomment-189081217
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/391#issuecomment-189078630
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/388
HAWQ-453. Do not allocate query resource in prepare stage for prepared
statement
The change includes:
1. In SPI prepare, we generate plan, get and save query resource parameters
2. In
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/384#issuecomment-188552764
LTGM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/383#issuecomment-188552638
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/382#issuecomment-188552566
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/381#issuecomment-188552288
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/372#issuecomment-187614853
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/369#issuecomment-187572206
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/361
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/366
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/366
HAWQ-429. Fix typo in HostnameVolumnInfo and HostDataVolumnInfo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huor/incubator-hawq
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/363#issuecomment-186967502
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/362#issuecomment-186967942
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/361
HAWQ-426. Fix memory leak for query and prepared statement due to
introduction of query resource parameters
The query resource parameters is kept in planned statement. So, the
resolution is
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/358#issuecomment-186048598
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/352
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/322
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/345
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/345#issuecomment-185519205
Good idea. For a quick fix, we can use CacheMemoryContext which is 8M at
maximum.
We are investigating on plan context for different queries including
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/352
HAWQ-418. Fix core dump when COPY data into table without any column
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huor/incubator-hawq
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/345
HAWQ-412. Allocate query resource for multiple EXECUTIONs in explicit and
implicit prepared statement
You can merge this pull request into a Git repository by running:
$ git pull https
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/342#issuecomment-184140976
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/335#issuecomment-184130178
The overall fix looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/335#discussion_r52875689
--- Diff: src/backend/optimizer/util/tlist.c ---
@@ -317,6 +317,10 @@ get_sortgrouplist_exprs(List *sortClauses, List
*targetList
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/343#issuecomment-184102996
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/340#discussion_r52854091
--- Diff: depends/libyarn/src/libyarnclient/LibYarnClient.cpp ---
@@ -649,7 +649,7 @@ int LibYarnClient::releaseResources(string
&jobId,int
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/316
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/327#issuecomment-179691649
It is better to set the pointers to NULLs after pfree.
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/333#issuecomment-179652141
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/331#issuecomment-179577899
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
1 - 100 of 292 matches
Mail list logo
