Re: Jira comments vs PR comments

2016-07-29 Thread Shivram Mani
Good to know ! On Mon, Jul 25, 2016 at 10:29 AM, Ting(Goden) Yao wrote: > this has been fixed by INFRA team: > https://issues.apache.org/jira/browse/INFRA-12310 check comments for > details. > Now it's PR linkonly, no more comments from PR on JIRA. > > > On Thu, Jul 21, 2016 at 7:50 PM Hong Wu

Re: Jira comments vs PR comments

2016-07-25 Thread Ting(Goden) Yao
this has been fixed by INFRA team: https://issues.apache.org/jira/browse/INFRA-12310 check comments for details. Now it's PR linkonly, no more comments from PR on JIRA. On Thu, Jul 21, 2016 at 7:50 PM Hong Wu wrote: > +1 > > 2016-07-21 10:21 GMT+08:00 Hubert Zhang : > > > +1. Comments on PR s

Re: Jira comments vs PR comments

2016-07-21 Thread Hong Wu
+1 2016-07-21 10:21 GMT+08:00 Hubert Zhang : > +1. Comments on PR should only be related to the code, not design. > > On Thu, Jul 21, 2016 at 1:59 AM, Goden Yao wrote: > > > I filed an infra ticket to disconnect this integration between github PR > > and JIRA comment: > > https://issues.apache.o

Re: Jira comments vs PR comments

2016-07-20 Thread Hubert Zhang
+1. Comments on PR should only be related to the code, not design. On Thu, Jul 21, 2016 at 1:59 AM, Goden Yao wrote: > I filed an infra ticket to disconnect this integration between github PR > and JIRA comment: > https://issues.apache.org/jira/browse/INFRA-12310 > > On Tue, Jul 19, 2016 at 10:3

Re: Jira comments vs PR comments

2016-07-20 Thread Goden Yao
I filed an infra ticket to disconnect this integration between github PR and JIRA comment: https://issues.apache.org/jira/browse/INFRA-12310 On Tue, Jul 19, 2016 at 10:31 PM Lili Ma wrote: > Agree! Just keeping the "issue links to" is enough to track the pull > request. Leaving the comments on

Re: Jira comments vs PR comments

2016-07-19 Thread Lili Ma
Agree! Just keeping the "issue links to" is enough to track the pull request. Leaving the comments on JIRA there is more neat. Thanks Lili 2016-07-20 10:34 GMT+08:00 Paul Guo : > +1. Github has already have fine-grained notification mechanism. I think > JIRA > could just pull the initial git

Re: Jira comments vs PR comments

2016-07-19 Thread Paul Guo
+1. Github has already have fine-grained notification mechanism. I think JIRA could just pull the initial git pull request info, not each comment in github. I guess this is either a JIRA configuration issue or an asf/infrustructure issue. 2016-07-20 2:57 GMT+08:00 Goden Yao : > 2nd that. JIRA r

Re: Jira comments vs PR comments

2016-07-19 Thread Goden Yao
2nd that. JIRA right now can already link to the PR under "issue links to" section. (e.g.: https://issues.apache.org/jira/browse/HAWQ-936 ) Not sure if that was automatic or manual but I prefer that way instead of auto-pulling every PR comment into the JIRA (even closing PR is a comment). JIRA dis

Jira comments vs PR comments

2016-07-19 Thread Shivram Mani
Its great that Jira and github has been linked, but this integration is also making it hard for us to skim through actual comments posted in Jira. Jiras usually end up being innundated with every single comment posted in the pull request. This makes it hard for us to actually read through/search fo