Build failed in Jenkins: HBase-TRUNK #2667

2012-02-22 Thread Apache Jenkins Server
See Changes: [stack] HBASE-5423 Regionserver may block forever on waitOnAllRegionsToClose when aborting [stack] HBASE-5424 HTable meet NPE when call getRegionInfo() -- REVERT [stack] HBASE-5424 HTable meet NPE when call getRegionInfo()

Build failed in Jenkins: HBase-TRUNK-security #120

2012-02-22 Thread Apache Jenkins Server
See Changes: [stack] HBASE-5424 HTable meet NPE when call getRegionInfo() -- [...truncated 2021 lines...] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.086 sec Running org

Re: Some HBase M/R confusion

2012-02-22 Thread lars hofhansl
Then we should rename it already :) On the site it is still called "The HBase Book". For record. For the first approach I had forgotten to add hadoop/conf to my hbase classpath. It also works if I add -conf hadoop/conf/core-site.xml to the export command. -- Lars __

Re: Some HBase M/R confusion

2012-02-22 Thread Stack
On Wed, Feb 22, 2012 at 9:14 PM, lars hofhansl wrote: > Either way we need to update the book I think. > Its not 'the book'. Its the 'reference guide'. One if published by O'Reilly. The latter by our man Doug Meil. > As for the protobufs. This is trunk, and it looks like this is related to

Re: Some HBase M/R confusion

2012-02-22 Thread lars hofhansl
Thanks Stack. Missed the "file:" part in the first case... Stupid... Must pickup an hbase-site.xml from somewhere else (or more likely just using the defaults, because it can't fine one). Either way we need to update the book I think. As for the protobufs. This is trunk, and it looks like th

Re: Some HBase M/R confusion

2012-02-22 Thread Stack
On Wed, Feb 22, 2012 at 6:36 PM, lars hofhansl wrote: > 1. The HBase book states to run M/R jobs like export here: > http://hbase.apache.org/book/ops_mgt.html#export > bin/hbase org.apache.hadoop.hbase.mapreduce.Export > [ [ []]] > This is running the Export tool, i.e. the Export class's main

Re: Some HBase M/R confusion

2012-02-22 Thread lars hofhansl
I saw a bunch of security related classes in the trace. I'll try with a non-secure branch and file a jira if the problem is not present there. Any input on the first issue? -- Lars From: Ted Yu To: dev@hbase.apache.org; lars hofhansl Sent: Wednesday, Febru

Re: Some HBase M/R confusion

2012-02-22 Thread Ted Yu
Lars: Is the second problem present in insecure HBase ? Thanks On Wed, Feb 22, 2012 at 6:36 PM, lars hofhansl wrote: > According to the documentation there are two ways to run HBase M/R jobs: > > > 1. The HBase book states to run M/R jobs like export here: > http://hbase.apache.org/book/ops_mgt

Some HBase M/R confusion

2012-02-22 Thread lars hofhansl
According to the documentation there are two ways to run HBase M/R jobs: 1. The HBase book states to run M/R jobs like export here: http://hbase.apache.org/book/ops_mgt.html#export bin/hbase org.apache.hadoop.hbase.mapreduce.Export [ [ []]] 2. Whereas the Javadoc says here: http://hbase.apa

Re: advice w.r.t. wild card import

2012-02-22 Thread Mikhail Bautin
+1 on avoiding using wildcard imports. Eclipse's "Organize Imports" command gets rid of them pretty well. Thanks, --Mikhail On Wed, 22 Feb 2012 12:46:47 -0800, Ted Yu wrote: Hi, If you wonder why occasionally we have broken Jenkins build, I can give you one reason. Look at the followin

Build failed in Jenkins: HBase-TRUNK-security #119

2012-02-22 Thread Apache Jenkins Server
See Changes: [nspiegelberg] [jira] [HBASE-5332] Deterministic Compaction Jitter Summary: Changing the jitter in major compactions to be deterministic, so reboots don't cause a time-based compaction storm. This implementation seeds

Re: advice w.r.t. wild card import

2012-02-22 Thread Pan, Thomas
Which check-in rules have we set up for our SCM? -Thomas On 2/22/12 12:46 PM, "Ted Yu" wrote: >Hi, >If you wonder why occasionally we have broken Jenkins build, I can give >you >one reason. > >Look at the following import in TestMasterFailover: >import org.apache.hadoop.hbase.*; > >When a new t

Jenkins build is back to normal : HBase-0.92-security #94

2012-02-22 Thread Apache Jenkins Server
See

Jenkins build is back to normal : HBase-TRUNK #2666

2012-02-22 Thread Apache Jenkins Server
See

Re: Mocking classes for unit tests Was: asynchbase-1.2.0-rc1 is available for download

2012-02-22 Thread Ted Dunning
Actually jmockit uses byte code patching so you may suffer less reflection overhead than expected. My guess is that powermock is doing something quite similar. Sent from my iPhone On Feb 22, 2012, at 9:29 AM, Jesse Yates wrote: > Only long standing problem I've found with it is that, by nece

Re: Mocking classes for unit tests Was: asynchbase-1.2.0-rc1 is available for download

2012-02-22 Thread Ted Dunning
Jmockit has worked well for both mocking and stubbing for me. My problem was System.currentTimeMillis and if you can patch that you can patch most anything. Sent from my iPhone On Feb 22, 2012, at 9:23 AM, Ted Yu wrote: > Benoit's comment is directly related to our practice, especially when

advice w.r.t. wild card import

2012-02-22 Thread Ted Yu
Hi, If you wonder why occasionally we have broken Jenkins build, I can give you one reason. Look at the following import in TestMasterFailover: import org.apache.hadoop.hbase.*; When a new test was added which used ClusterStatus, there was no import to be added in TRUNK because of the above impor

Re: Mocking classes for unit tests Was: asynchbase-1.2.0-rc1 is available for download

2012-02-22 Thread Ted Yu
I logged https://issues.apache.org/jira/browse/HBASE-5456 I think we should make "for test only" methods private in the above JIRA. Feel free to comment on the JIRA or in this thread. Thanks On Wed, Feb 22, 2012 at 12:24 PM, tsuna wrote: > On Wed, Feb 22, 2012 at 9:23 AM, Ted Yu wrote: > > B

Re: Mocking classes for unit tests Was: asynchbase-1.2.0-rc1 is available for download

2012-02-22 Thread Todd Lipcon
On Wed, Feb 22, 2012 at 12:24 PM, tsuna wrote: > On Wed, Feb 22, 2012 at 9:23 AM, Ted Yu wrote: >> Benoit's comment is directly related to our practice, especially when we >> add new methods which are only called by unit tests. > > I didn't dare to say it, but now that you do… :P > > HBase expose

Re: Mocking classes for unit tests Was: asynchbase-1.2.0-rc1 is available for download

2012-02-22 Thread tsuna
On Wed, Feb 22, 2012 at 9:23 AM, Ted Yu wrote: > Benoit's comment is directly related to our practice, especially when we > add new methods which are only called by unit tests. I didn't dare to say it, but now that you do… :P HBase exposes a TON of implementation details in public APIs. Makes t

Re: HBase wire compatibility

2012-02-22 Thread tsuna
On Thu, Feb 16, 2012 at 3:55 PM, Jeff Whiting wrote: > It seems like the only heavy part of the client would be the zookeeper > interactions (forgive my ignorance if I'm wrong). ZooKeeper interactions are extremely simple for a client, that's not where the heavy part is. All a client needs to do

Re: Meeting notes

2012-02-22 Thread Enis Söztutar
Great write up. +1 on branching. Enis On Wed, Feb 22, 2012 at 10:23 AM, Andrew Purtell wrote: > > I didn't fill in any target version yet... before I did so, I had the > > idea that we may want to do this work on a feature branch. > > +1, given the feature branch won't be long lived. > > > Best

Re: Meeting notes

2012-02-22 Thread Andrew Purtell
> I didn't fill in any target version yet... before I did so, I had the > idea that we may want to do this work on a feature branch. +1, given the feature branch won't be long lived. Best regards,     - Andy Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom Wh

Re: Mocking classes for unit tests Was: asynchbase-1.2.0-rc1 is available for download

2012-02-22 Thread Jesse Yates
I put forward rolling in Powermock a while back, but it always seems a bit overkill for just one or two methods. However, if we make using powermock a 'best practice' going forward, then it becomes reasonable. Powermock is really nice in that not only can you access private methods and mock final

Mocking classes for unit tests Was: asynchbase-1.2.0-rc1 is available for download

2012-02-22 Thread Ted Yu
Benoit's comment is directly related to our practice, especially when we add new methods which are only called by unit tests. FYI -- Forwarded message -- From: tsuna Date: Wed, Feb 22, 2012 at 9:13 AM Subject: Re: asynchbase-1.2.0-rc1 is available for download To: Jim Scott Cc:

Jenkins build is back to normal : HBase-0.92 #299

2012-02-22 Thread Apache Jenkins Server
See