Re: Review Request: HBASE-50: Snapshot of table

2010-09-06 Thread Chongxin Li
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/467/ --- (Updated 2010-09-06 04:34:53.459404) Review request for hbase. Changes ---

Re: Review Request: HBASE-50: Snapshot of table

2010-08-19 Thread Chongxin Li
(add_snapshot_family.rb) to add snapshot family for META and remove method HMaster.addSnapshotFamily. The script is not tested yet (how?) - Chongxin On 2010-08-19 08:35:37, Chongxin Li wrote: > > --- > This is an automatically generat

Re: Review Request: HBASE-50: Snapshot of table

2010-08-19 Thread Chongxin Li
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/467/ --- (Updated 2010-08-19 08:35:37.043957) Review request for hbase. Summary ---

Re: Review Request: HBASE-50: Snapshot of table

2010-08-14 Thread Chongxin Li
ttp://review.cloudera.org/r/467/#comment2942> Why set retries number to 1 here? Since I use MetaUtils in HMaster to scan root region when system is started, this would have a impact for other parts of the system. Is it OK to remove this? - Chongxin On 2010-08-14 01:30:00, Chongxin Li

Re: Review Request: HBASE-50: Snapshot of table

2010-08-14 Thread Chongxin Li
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/467/ --- (Updated 2010-08-14 01:30:00.941083) Review request for hbase. Changes ---

Re: Review Request: HBASE-50: Snapshot of table

2010-08-13 Thread Chongxin Li
mail. To reply, visit: http://review.cloudera.org/r/467/#review874 --- On 2010-08-12 02:43:42, Chongxin Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/46

Re: Review Request: HBASE-50: Snapshot of table

2010-08-12 Thread Chongxin Li
case > > where the data has been migrated from an older hbase version; it won't have > > this column family in .META. We should make a little migration script that > > adds it or on start of new version, check for it and if not present, create > > it. > > Cho

Re: Review Request: HBASE-50: Snapshot of table

2010-08-12 Thread Chongxin Li
----- On 2010-08-12 02:43:42, Chongxin Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/467/ >

Re: Review Request: HBASE-50: Snapshot of table

2010-08-12 Thread Chongxin Li
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/467/ --- (Updated 2010-08-12 02:43:42.872855) Review request for hbase. Summary ---

Re: Review Request: HBASE-50: Snapshot of table

2010-08-12 Thread Chongxin Li
oudera.org/r/467/diff/3/?file=6024#file6024line2355> > > > > If snapshot fails, do we have to do cleanup? HRegions just quit the snapshot mode if fails. The master would be notified with failure and do the clean up work for the whole snapshot. - Chongxin ---

Re: Review Request: HBASE-50: Snapshot of table

2010-08-12 Thread Chongxin Li
- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/467/#review823 --- On 2010-08-09 03:52:11, Chongxin Li wrote: > > --- > This

Re: Review Request: HBASE-50: Snapshot of table

2010-08-11 Thread Chongxin Li
e-mail. To reply, visit: http://review.cloudera.org/r/467/#review829 ------- On 2010-08-09 03:52:11, Chongxin Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/467/

Re: Review Request: HBASE-50: Snapshot of table

2010-08-11 Thread Chongxin Li
- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/467/#review830 ------- On 2010-08-09 03:52:11, Chongxin Li wrote: > > ---

Re: Review Request: HBASE-50: Snapshot of table

2010-08-11 Thread Chongxin Li
cle.com/javase/1.4.2/docs/api/java/io/DataOutput.html#writeBoolean%28boolean%29 Thus value (byte)1 was written if it is the top file region (isTopFileRegion is true). That is exactly the same as current value of TOP. For the same reason, this deserialization would work for the references in the old data, right? That's why we can not use

Re: Review Request: HBASE-50: Snapshot of table

2010-08-10 Thread Chongxin Li
here is no region info saved in each reference row. Thus reference row which is a combination of SNAPSHOT_PREFIX and region name is parsed to obtain the region name. That's why we need this method. - Chongxin --- This is an automatical

Re: Review Request: HBASE-50: Snapshot of table

2010-08-10 Thread Chongxin Li
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/467/#review799 --- On 2010-08-09 03:52:11, Chongxin Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Review Request: HBASE-50: Snapshot of table

2010-08-09 Thread Chongxin Li
created at master startup and destroyed at master shutdown, and can > > coordinate multiple snapshots over its lifetime? would be good to document > > how this fits into the overall design, and perhaps refactor into one part > > that is master-global and another part th

Re: Review Request: HBASE-50: Snapshot of table

2010-08-09 Thread Chongxin Li
http://review.cloudera.org/r/467/#review631 ------- On 2010-08-09 03:52:11, Chongxin Li wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request: HBASE-50: Snapshot of table

2010-08-09 Thread Chongxin Li
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/467/ --- (Updated 2010-08-09 03:52:11.875655) Review request for hbase. Changes ---

Review Request: HBASE-50: Snapshot of table

2010-08-01 Thread Chongxin Li
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/467/ --- Review request for hbase. Summary --- This patch includes the first three su

Re: Review Request: HBASE-2792: Create a better way to chain log cleaners

2010-07-29 Thread Chongxin Li
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/372/ --- (Updated 2010-07-29 06:51:56.166539) Review request for hbase. Changes ---

Re: Review Request: HBASE-2792: Create a better way to chain log cleaners

2010-07-24 Thread Chongxin Li
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/372/ --- (Updated 2010-07-24 05:10:08.798554) Review request for hbase. Changes --- Si

Re: Review Request: HBASE-2792: Create a better way to chain log cleaners

2010-07-22 Thread Chongxin Li
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/372/ --- (Updated 2010-07-22 23:00:05.908203) Review request for hbase. Changes --- HB

Review Request: HBASE-2792: Create a better way to chain log cleaners

2010-07-22 Thread Chongxin Li
--- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/372/ --- Review request for hbase. Summary --- HBASE-2792: Create a better way to chain