Re: [DISCUSS] Allow namespace admins to clone snapshots created by them

2023-01-18 Thread Duo Zhang
Approved the PR on github. Please go ahead. Szabolcs Bukros 于2023年1月16日周一 22:07写道: > > I would be fine with adding this only to 2.6 and 3.0. I only proposed the > other branches because of the perceived low impact of the change. > This change is not important enough to make a sooner release

Re: [DISCUSS] Allow namespace admins to clone snapshots created by them

2023-01-16 Thread Szabolcs Bukros
I would be fine with adding this only to 2.6 and 3.0. I only proposed the other branches because of the perceived low impact of the change. This change is not important enough to make a sooner release necessary. If the change is accepted could I please get a review for the PR?

Re: [DISCUSS] Allow namespace admins to clone snapshots created by them

2023-01-03 Thread Duo Zhang
+1 on releasing 2.6.0 sooner. And I think it is time to EOL 2.4.x after we release 2.6.0? Bryan Beaudreault 于2023年1月3日周二 21:02写道: > > I think development is done on TLS. We are just waiting on requested > testing. Andor was working on that, but I believe he had some stuff come up > at his work.

Re: [DISCUSS] Allow namespace admins to clone snapshots created by them

2023-01-03 Thread Bryan Beaudreault
I think development is done on TLS. We are just waiting on requested testing. Andor was working on that, but I believe he had some stuff come up at his work. I also want to get backups in place, but there is 1 backwards compatibility issue to work through. Hoping to have that squared away soon.

Re: [DISCUSS] Allow namespace admins to clone snapshots created by them

2022-12-31 Thread Andrew Purtell
+1 If this is needed soon in a release we could start on 2.6.0? (How is TLS RPC coming along? - that would be the big ticket item.) > On Dec 23, 2022, at 7:06 AM, 张铎 wrote: > > This is a behavior change, it makes non admin users can clone snapshot. > > For me I do not think we should

Re: [DISCUSS] Allow namespace admins to clone snapshots created by them

2022-12-23 Thread Duo Zhang
This is a behavior change, it makes non admin users can clone snapshot. For me I do not think we should include changes like this in a patch release, unless it is considered as a critical bug which must be fixed. Thanks. Szabolcs Bukros 于2022年11月30日周三 00:06写道: > > This should not break any

Re: [DISCUSS] Allow namespace admins to clone snapshots created by them

2022-11-29 Thread Szabolcs Bukros
This should not break any existing use case so I see no reason to not add this to branch-2.5 and branch-2.4. On Thu, Nov 24, 2022 at 3:03 AM 张铎(Duo Zhang) wrote: > I'm OK with this change. > > But maybe we still need to determine which branches we can apply this > change to? Is it OK to include

Re: [DISCUSS] Allow namespace admins to clone snapshots created by them

2022-11-23 Thread Duo Zhang
I'm OK with this change. But maybe we still need to determine which branches we can apply this change to? Is it OK to include this change for branch-2.5 and branch-2.4? Tak Lon (Stephen) Wu 于2022年11月22日周二 06:31写道: > > FYI the PR is https://github.com/apache/hbase/pull/4885 and >

Re: [DISCUSS] Allow namespace admins to clone snapshots created by them

2022-11-21 Thread Tak Lon (Stephen) Wu
FYI the PR is https://github.com/apache/hbase/pull/4885 and https://issues.apache.org/jira/browse/HBASE-27493. the proposal seems to be, should we allow cloning snapshot to any namespace if they're not the global admin. logically, it should be fine because they're the admin for the namespace,

[DISCUSS] Allow namespace admins to clone snapshots created by them

2022-11-21 Thread Szabolcs Bukros
Hi Everyone, Creating a snapshot requires table admin permissions. But cloning it requires global admin permissions unless the user owns the snapshot and wants to recreate the original table the snapshot was based on using the same table name. This puts unnecessary load on the few users having