Re: [DISCUSS] Remove FirstKeyValueMatchingQualifiersFilter

2021-07-19 Thread Huang Zhuoyue
Thanks for the suggestions! I am going to keep the proto and deprecate the proto message. If there are any different opinions, we can still discuss them here or in jira HBASE-26091. -- Original -- From:  "(Duo Zhang)";https://github.com/protocolbuffers/pro

Re: [DISCUSS] Remove FirstKeyValueMatchingQualifiersFilter

2021-07-19 Thread Duo Zhang
BTW, you can try to deprecated proto message https://github.com/protocolbuffers/protobuf/issues/1734 Stack 于2021年7月19日周一 下午11:15写道: > I suggest keeping the proto. > S > > On Sat, Jul 17, 2021 at 1:15 PM 黄卓越 wrote: > > > Hi, > > > > As https://issues.apache.org/jira/browse/HBASE-13347 describes

Re: [DISCUSS] Remove FirstKeyValueMatchingQualifiersFilter

2021-07-19 Thread Stack
I suggest keeping the proto. S On Sat, Jul 17, 2021 at 1:15 PM 黄卓越 wrote: > Hi, > > As https://issues.apache.org/jira/browse/HBASE-13347 describes, the > FirstKeyValueMatchingQualifiersFilter was deprecated in 2.0 and will be > removed in 3.0. Now we need to remove it in 3.0 but there are proto

Re: [DISCUSS] Remove FirstKeyValueMatchingQualifiersFilter

2021-07-18 Thread Duo Zhang
For me, I think we'd better keep the proto, so we could tell the client that this filter is not supported any more, by throwing a DoNotRetryIOException. 黄卓越 于2021年7月18日周日 上午4:17写道: > Hi, > > As https://issues.apache.org/jira/browse/HBASE-13347 describes, the > FirstKeyValueMatchingQualifiersFilt

[DISCUSS] Remove FirstKeyValueMatchingQualifiersFilter

2021-07-17 Thread 黄卓越
Hi, As https://issues.apache.org/jira/browse/HBASE-13347 describes, the FirstKeyValueMatchingQualifiersFilter was deprecated in 2.0 and will be removed in 3.0. Now we need to remove it in 3.0 but there are proto declareation of FirstKeyValueMatchingQualifiersFilter in Filter.proto. If the pr

[DISCUSS] Remove FirstKeyValueMatchingQualifiersFilter

2021-07-16 Thread Huang Zhuoyue
Hi, As https://issues.apache.org/jira/browse/HBASE-13347 describes, the FirstKeyValueMatchingQualifiersFilter was deprecated in 2.0 and will be removed in 3.0. Now we need to remove it in 3.0 but there are proto declareation of FirstKeyValueMatchingQualifiersFilter in Filter.proto. If the